Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging PPO training #57

Merged
merged 15 commits into from
Sep 30, 2022
Merged

Debugging PPO training #57

merged 15 commits into from
Sep 30, 2022

Conversation

jcallaham
Copy link
Collaborator

@jcallaham jcallaham commented Sep 27, 2022

Explanation

Previously the cylinder environment would train with the PPO implementation in RLlib but the performance would not improve (fixes #49). I think there were a few issues, including

  • Environments (and their flows/timesteppers) not properly resetting
  • Control inputs not being properly applied within rollouts

These at least seem to be fixed, although now there's a new issue where RLlib crashes after 3 epochs with a hard-to-understand error message (see #55).

Current status

  • All tests passing
  • RLlib will run without error for some amount of time and then crash

Plan

The way the package is currently structured makes the memory issue a bit hard to debug, especially with recent version changes in OpenAI Gym. Even though our package is in a sense "broken" at this point with respect to training RL agents, it's no more broken than it was before this PR. Since fixing this issue may require resolving #54, #55, and #56, I plan to merge as-is and then try to work through all these with a cleaner package (post-#56).

@jcallaham jcallaham self-assigned this Sep 27, 2022
@jcallaham
Copy link
Collaborator Author

Also fixes #55

@jcallaham jcallaham marked this pull request as ready for review September 30, 2022 09:01
@jcallaham jcallaham merged commit 208fcf4 into main Sep 30, 2022
@jcallaham jcallaham deleted the jc/ppo-train-debug branch September 30, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Training signal from environments in RLlib
1 participant