-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugging PPO training #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Previously the cylinder environment would train with the PPO implementation in RLlib but the performance would not improve (fixes #49). I think there were a few issues, including
These at least seem to be fixed, although now there's a new issue where RLlib crashes after 3 epochs with a hard-to-understand error message (see #55).
Current status
Plan
The way the package is currently structured makes the memory issue a bit hard to debug, especially with recent version changes in OpenAI Gym. Even though our package is in a sense "broken" at this point with respect to training RL agents, it's no more broken than it was before this PR. Since fixing this issue may require resolving #54, #55, and #56, I plan to merge as-is and then try to work through all these with a cleaner package (post-#56).