Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gym API Compliance #54

Closed
ludgerpaehler opened this issue Sep 11, 2022 · 1 comment · Fixed by #41
Closed

Gym API Compliance #54

ludgerpaehler opened this issue Sep 11, 2022 · 1 comment · Fixed by #41
Assignees
Labels
Paper-Release priority High-priority core feature

Comments

@ludgerpaehler
Copy link
Collaborator

The Gym API has just released its latest specifications, which interestingly for us contain breaking changes. They commit to maintaining all features from this point onward, but it would possibly make sense to have a look and see that we do not rely on any of the features which are affected by the breaking changes.

Here are the release notes:

https://github.com/openai/gym/releases/tag/0.26.0

Especially the step termination/truncation affects us directly probably.

@jcallaham
Copy link
Collaborator

Hmm, the Ray spec has "gym>=0.21.0,<0.24.0", which seems to resolve to 0.23.1 based on our current requirements.txt. Should we just go with the API expected by Ray for the time being? I assume they will eventually update as well though, so it'd be good to keep in mind either way.

@ludgerpaehler ludgerpaehler added this to the v1.0 Paper Release milestone Mar 24, 2023
@ludgerpaehler ludgerpaehler self-assigned this Mar 24, 2023
@ludgerpaehler ludgerpaehler added the priority High-priority core feature label Mar 30, 2023
@ludgerpaehler ludgerpaehler linked a pull request May 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paper-Release priority High-priority core feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants