feat(hard_fork): delayed ack should create commitment after rolling back acks #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yed-ack-should-create-commitment-after-rolling-back-acks
mtsitrin
merged commit e6122d1
into
mtsitrin/937-rollapp-hard-fork-hub-side
5 checks passed
mtsitrin
deleted the
1380-delayed-ack-should-create-commitment-after-rolling-back-acks
branch
mtsitrin
added a commit
that referenced
this pull request
Jan 13, 2025
…ition (#1467) * initial renames according to adr * reverting states * removed frozen notation. added revision number in rollapp object * cleanup * UT compiles * fixed state deletion on fraud * UT pass * fixed StateInfoByHeight UT * chainId revision check moved back to create rollapp. as it mess up dymns UT * PR comments * fixed basic sequencer logic to unbond all * feat(hard_fork): part2 (Delyayed ack callback) (#1355) * feat(hard_fork): Lightclient rollback (#1363) * feat(hard_fork): DRS and stateUpdate (#1369) * feat(hard_fork): rollapp fraud proposal (#1371) * feat(hard_fork): revision start height (#1373) * cleanup * lightClient doesn't trigger hard fork * clearing consesnsus state in descending order * fix UT * fraud proposal validates genesis bridge completed * validate revision in header.Header.Version.App * linter * linter * feat(hard_fork): delayed ack should create commitment after rolling back acks (#1383) * register proposal handler * updating next proposer on state infos * feat(hard_fork): update hard fork to support new `x/sequencer` updates (#1406) Co-authored-by: keruch <[email protected]> Co-authored-by: zale144 <[email protected]> Co-authored-by: Daniel T <[email protected]> Co-authored-by: Omri <[email protected]> Co-authored-by: Sergi Rene <[email protected]> Co-authored-by: Itzhak Bokris <[email protected]> * linter * UT fix * minor update to fraud proposal * delete pendingPacketsByAddress on the delayedAck * fixed seqeucner heoght pruning * fraud proposal supports future heights * fork hook doesn't return error * rotation doesn't go through sentinel proposer * simplified k.UpdateRollappPacketWithStatus interface * minor * minor log * fixed lightclient when setting canonical channel * feat(migrations): renamed vulnerable rollapps to obsolete (#1436) * Danwt/mtsitrin 937 rollapp hard fork hub side rewardee (#1441) * Danwt/fix upgrade conflicts (#1442) Co-authored-by: zale144 <[email protected]> Co-authored-by: keruch <[email protected]> * fix frozen * refactored to use Finalaization queue by rollappId * fixed pruning of finalization queue * cleared unused expected methods * linter * more cleanup * comments * fixed packet commitment and lightclient comments * return err on HardFork hooks * not forking on state update with obsolete DRS * linter * renamed fraudHeight * add error to kickProposer flow * fixed UT * deleteBySender moved to DeletePacket * fixed surprise linter * DRY pruneSigners code * feat(sequencer): hardforking when rotating to sentinel (#1455) Co-authored-by: danwt <[email protected]> * PR comments * AfterRecoveryFromHalt hook cleanup * fixed missing setConsensusMetadata. fixed kicked proposer unbond * fixed unbond store * refactor ValidateUpdatePessimistically to use single state info refactor canonical client check * updated expected keeper * dried out the state update hook * removed unused replace * unified canonical and ongoingvalidation * fix future height check * DRY canonical setting code * revert renaming * removed canonical setting on update headers * fixed tests compile --------- Co-authored-by: keruch <[email protected]> Co-authored-by: zale144 <[email protected]> Co-authored-by: Daniel T <[email protected]> Co-authored-by: Omri <[email protected]> Co-authored-by: Sergi Rene <[email protected]> Co-authored-by: Itzhak Bokris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1380