feat(hard_fork): Lightclient rollback #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtsitrin
commented
Oct 30, 2024
•
mtsitrin
commented
- Implement the OnHardFork hook in the LightClient module
- LightClient HardFork mode
- no LC updates are accepted until the fork is fully resolved.
- ResolveHardFork
Base automatically changed from
delyayedAck_callback
to
mtsitrin/937-rollapp-hard-fork-hub-side
October 31, 2024 08:51
mtsitrin
changed the title
mtsitrin
merged commit 617fa63
into
mtsitrin/937-rollapp-hard-fork-hub-side
3 of 5 checks passed
omritoptix
reviewed
Oct 31, 2024
| return nil | ||
| } | ||
|
|
||
| func (k Keeper) RollbackCanonicalClient(ctx sdk.Context, rollappId string, height uint64) { |
There was a problem hiding this comment.
not clear if height is target height or fraud height. I suggest renaming it accordingly.
Comment on lines
+30
to
32
| if h.GetRevisionHeight() < height { | ||
| return false | ||
| } |
There was a problem hiding this comment.
2 things here:
- if it's target height it should probably be
<=(unless it's the fraud height?) - the acennding iteration could be very pricy. desc iteration would be far more efficeint but I guess we don't have this api? thinking of 1 year of iteration.. not sure if the consensus states get pruned at some point?
There was a problem hiding this comment.
- it's
fraud height - consensus states got pruned after
TrustingPeriod. anyway I'll change it to descending
| } | ||
|
|
||
| // FIXME: assure there's no case with no proposer | ||
| func (k Keeper) getValidatorHashForHeight(ctx sdk.Context, rollappId string, height uint64) []byte { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.