Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump Cometbft to log proposer when proposal is rejected #2421

Merged
merged 1 commit into from
Oct 1, 2024
Merged

chore: Bump Cometbft to log proposer when proposal is rejected #2421

merged 1 commit into from
Oct 1, 2024

Conversation

teddyding
Copy link
Contributor

@teddyding teddyding commented Oct 1, 2024 •
edited by coderabbitai bot
Loading

Changelist

Adopt this commit which improves logging

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • Chores
    • Updated the Go version to 1.22.2.
    • Updated and replaced several dependencies, including those related to the Cosmos SDK and CometBFT, to ensure compatibility and alignment with the latest versions.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 1, 2024 •
edited
Loading

Walkthrough

The go.mod file for the github.com/dydxprotocol/v4-chain/protocol module has been updated to specify Go version 1.22.2. Dependencies have been added, updated, or replaced, particularly those related to the Cosmos SDK and CometBFT, with specific versions now pointing to the dYdX protocol's forks. The replace directives have been modified to ensure the use of these updated dependencies, impacting both direct and indirect dependencies within the module.

Changes

File Change Summary
protocol/go.mod Updated Go version to 1.22.2, added and updated dependencies, modified replace directives for Cosmos SDK and CometBFT libraries.

Poem

In the meadow where code does play,
A rabbit hops, hip-hip-hooray!
With go.mod fresh and bright,
Dependencies dance in the light.
Cosmos and CometBFT, oh what a sight!
Let’s code and leap, from day to night! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ce94992 and b8fb015.

⛔ Files ignored due to path filters (1)
  • protocol/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • protocol/go.mod (1 hunks)
🔇 Additional comments (1)
protocol/go.mod (1)

466-466: LGTM! Dependency updated as per PR objective

The CometBFT dependency has been updated to the specific commit in the dYdX fork. This change aligns with the PR objective to enhance logging by including the proposer when a proposal is rejected.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@teddyding teddyding marked this pull request as ready for review October 1, 2024 17:48
@teddyding teddyding requested a review from a team as a code owner October 1, 2024 17:48
@teddyding
Copy link
Contributor Author

@Mergifyio backport release/protocol/v7.x

@teddyding
Copy link
Contributor Author

@Mergifyio backport release/protocol/v6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 1, 2024 •
edited
Loading

backport release/protocol/v7.x

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 1, 2024 •
edited
Loading

backport release/protocol/v6.x

✅ Backports have been created

@teddyding teddyding merged commit 2097b85 into main Oct 1, 2024
22 checks passed
@teddyding teddyding deleted the td/bump-comet branch October 1, 2024 21:12
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@teddyding @mergify
chore: Bump Cometbft to log proposer when proposal is rejected (#2421)
ad6cf24 
(cherry picked from commit 2097b85)
@mergify mergify bot mentioned this pull request Oct 1, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@teddyding @mergify
chore: Bump Cometbft to log proposer when proposal is rejected (#2421)
fb72187 
(cherry picked from commit 2097b85)
@mergify mergify bot mentioned this pull request Oct 1, 2024
Merged
6 tasks
teddyding added a commit that referenced this pull request Oct 1, 2024
@mergify @teddyding
chore: Bump Cometbft to log proposer when proposal is rejected (backp…
cb67272 
…ort #2421) (#2427)

Co-authored-by: Teddy Ding <[email protected]>
teddyding added a commit that referenced this pull request Oct 1, 2024
@mergify @teddyding
chore: Bump Cometbft to log proposer when proposal is rejected (backp…
afd3906 
…ort #2421) (#2428)

Co-authored-by: Teddy Ding <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Oct 22, 2024
Merged
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 6, 2024
Merged
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 20, 2024
Merged
6 tasks
adamfraser pushed a commit that referenced this pull request Nov 20, 2024
@teddyding @adamfraser
chore: Bump Cometbft to log proposer when proposal is rejected (#2421)
253f98d
@coderabbitai coderabbitai bot mentioned this pull request Nov 29, 2024
Open
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 17, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentwschau vincentwschau vincentwschau approved these changes

Assignees
No one assigned
Labels
non-breaking
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teddyding @vincentwschau