Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for ASA-2024-0012 and 0013. #2666

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Patch for ASA-2024-0012 and 0013. #2666

merged 3 commits into from
Jan 8, 2025

Conversation

vincentwschau
Copy link
Contributor

@vincentwschau vincentwschau commented Dec 17, 2024 •
edited by coderabbitai bot
Loading

Changelist

Upgrades the cosmos sdk fork dependency to one with a patch for the two security issues.
The patch was updated to have allow up to 10,000 max calls rather than 100 to account for large governance proposals that exist on dYdX chain. See details here.

Test Plan

N/A

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Updated dependency versions for improved compatibility and performance.

  • Bug Fixes

    • Resolved issues related to outdated dependencies, enhancing overall stability.

@vincentwschau vincentwschau requested a review from a team as a code owner December 17, 2024 21:26
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2024 •
edited
Loading

Walkthrough

This pull request updates the go.mod file for the github.com/dydxprotocol/v4-chain/protocol module. The key modifications include changing the Go version to 1.23.3 and updating various dependencies to their latest versions. Notable updates involve the Cosmos SDK and IBC Go modules, along with several indirect dependencies. Additionally, the replace directives have been adjusted to ensure compatibility with the updated packages.

Changes

File Change Summary
protocol/go.mod - Updated Go version to 1.23.3
- Updated github.com/cosmos/cosmos-sdk from v0.50.6-0.20241219194626-713334f028e7 to v0.50.6-0.20250107211707-20a978a867c1
- Updated github.com/cosmos/ibc-go/v8 from v8.0.0 to v8.5.1
- Updated github.com/99designs/keyring from v1.2.0 to v1.2.2
- Updated github.com/ory/dockertest/v3 from v3.3.5+incompatible to v3.10.0
- Modified replace directives for various dependencies

Possibly related PRs

Suggested labels

backport/protocol/v6.x, backport/protocol/v7.x

Suggested reviewers

  • ttl33
  • teddyding

Poem

🐰 Hop, hop, dependencies dance!
Versions update with every glance
Go modules shift and sway
Cosmos SDK finds a brighter day
Dependency harmony, oh so neat! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb18dec and b26708a.

⛔ Files ignored due to path filters (1)
  • protocol/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • protocol/go.mod (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • protocol/go.mod
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: test-sim-multi-seed-short
  • GitHub Check: test-race
  • GitHub Check: test-coverage-upload
  • GitHub Check: container-tests
  • GitHub Check: Summary

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vincentwschau vincentwschau merged commit 2a79ca0 into main Jan 8, 2025
22 checks passed
@vincentwschau vincentwschau deleted the vincentc/asa-2024-0012+0013-patch branch January 8, 2025 18:45
@vincentwschau
Copy link
Contributor Author

vincentwschau commented Jan 8, 2025 •
edited
Loading

@Mergifyio backport release/protocol/v8.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 8, 2025 •
edited
Loading

backport release/protocol/v8.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 8, 2025
@vincentwschau @mergify
Patch for ASA-2024-0012 and 0013. (#2666)
33c2d9b 
(cherry picked from commit 2a79ca0)

# Conflicts:
#	protocol/go.mod
#	protocol/go.sum
@mergify mergify bot mentioned this pull request Jan 8, 2025
Merged
6 tasks
vincentwschau added a commit that referenced this pull request Jan 8, 2025
@mergify @vincentwschau
Patch for ASA-2024-0012 and 0013. (backport #2666) (#2675)
2e57c62 
Co-authored-by: vincentwschau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddyding teddyding teddyding approved these changes

Assignees
No one assigned
Labels
protocol
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentwschau @teddyding