[OTE-664] Change docker-compose to new syntax #2035
Conversation
WalkthroughThe recent changes enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
jerryfan01234
force-pushed
the
update-makefile
branch
from
3ef1baf to
59a2836
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/protocol-benchmark.yml (1 hunks)
- .github/workflows/protocol-test.yml (1 hunks)
- protocol/Makefile (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- protocol/Makefile
Additional comments not posted (2)
.github/workflows/protocol-benchmark.yml (1)
31-33: LGTM! Pruning Docker system is a good practice.The addition of the step to prune the Docker system before running benchmarks is a good practice to free up disk space and ensure a clean environment.
.github/workflows/protocol-test.yml (1)
108-110: LGTM! Pruning Docker system is a good practice.The addition of the step to prune the Docker system before starting the localnet is a good practice to free up disk space and ensure a clean environment.
jerryfan01234
changed the title
| @@ -28,6 +28,9 @@ jobs: | |||
| uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: 1.22 | |||
| - name: Prune Docker system to free up space | |||
| run: | | |||
| docker system prune -a --volumes -f | |||
There was a problem hiding this comment.
Have you seen CI fail with disk space issues?
There was a problem hiding this comment.
Yea, the first PR with just the docker compose change actually triggered this, which is why I included prune
|
@Mergifyio backport release/protocol/v5.2.x |
|
https://github.com/Mergifyio backport release/protocol/v6.x |
✅ Backports have been created
|
✅ Backports have been created
|
(cherry picked from commit 6930857) # Conflicts: # .github/workflows/protocol-test.yml
(cherry picked from commit 6930857)
Co-authored-by: jerryfan01234 <[email protected]>
Co-authored-by: jerryfan01234 <[email protected]> Co-authored-by: roy-dydx <[email protected]>
Changelist
changed docker-compose to docker compose in makefile
github deprecated v1 docker (actions/runner-images#9557) so
docker-composeis no longer recognized during github auto reviews -> liveness test failingTest Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
docker composecommands for local network management, enhancing clarity and maintainability.