Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Flutter loading time and web renderers #4

Merged
merged 6 commits into from
Feb 25, 2023
Merged

Conversation

LuchoTurtle
Copy link
Member

related to dwyl/app#315

This PR improves the Flutter app by adding a splash screen and writes a section about the Lighthouse metrics difference between using a canvaskit and html renderer.

@LuchoTurtle LuchoTurtle added documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality discuss Share your constructive thoughts on how to make progress with this issue in-progress An issue or pull request that is being worked on by the assigned person labels Feb 24, 2023
@LuchoTurtle LuchoTurtle self-assigned this Feb 24, 2023
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Feb 24, 2023
@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Feb 24, 2023
README.md Outdated Show resolved Hide resolved
@nelsonic
Copy link
Member

When I visit: https://flutter-phoenix-channels-frontend.fly.dev/ I see the loading screen:

image

When I manually refresh the page it loads the actual app:
https://user-images.githubusercontent.com/194400/221338985-17058d41-feee-4cf1-9e9b-3451e035e7da.mov

I wasn't able to reproduce this in any other browser so I consider it a "fluke" not an issue worth reporting. 👌

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle good write-up. You've changed my mind on the splash screens. It's not as bad as I suspected and substantially improves perf score on lighthouse. Nice one. 👌

@nelsonic nelsonic merged commit fa735b7 into main Feb 25, 2023
@nelsonic nelsonic deleted the splash-screen branch February 25, 2023 05:19
@nelsonic
Copy link
Member

CC: @SimonLab worth checking this one over to update your knowledge. 💭

@LuchoTurtle
Copy link
Member Author

When I manually refresh the page it loads the actual app

This is perhaps because the initialization of the engine only occurs when the user first visits the page. The downloaded elements are cached on subsequent visits.

@nelsonic nelsonic mentioned this pull request Mar 1, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed discuss Share your constructive thoughts on how to make progress with this issue documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants