Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Loading Screen #319

Closed
10 tasks done
nelsonic opened this issue Mar 1, 2023 · 2 comments · Fixed by #321
Closed
10 tasks done

Feat: Loading Screen #319

nelsonic opened this issue Mar 1, 2023 · 2 comments · Fixed by #321
Assignees
Labels
flutter Flutter related issues good first issue help wanted If you can help make progress with this issue, please comment! needs-ui A feature idea that needs UI in order to be discussed/built. priority-1 Highest priority issue. This is costing us money every minute that passes. T2h Time Estimate 2 Hours

Comments

@nelsonic
Copy link
Member

nelsonic commented Mar 1, 2023

As noted in our mini experiment for loading screen: dwyl/flutter-phoenix-channels-demo#4
The code required to create a loading screen is minimal and does increase the bundle size.
It loads immediately because it's just HTML and gives the person viewing (waiting) some visual indication of progress while the bundle (main.dart.js) is downloading.

Let's implement it for the Flutter Web App so that we can both give people a sense of progress ⏳
and give Google something to see while the app is loading ... 🤖

Todo

image

.dwyl-bg-dark-gray {
background-color: #354046;
}
  • Vertically + Horizontally centred dwyl Logo e.g: 64 x 64 px if we have one (smaller the better to reduce load time)
    • Logo Should have transparent background
  • Centred tagline below the logo:
  • No CSS transitions or any superfluous JS (for now ...) just the simplest/fastest-loading screen possible that is replaced as soon as the main.dart.js is loaded. 🙏
  • Please avoid importing a CSS library if you can. Borrow the styles from Tailwind if you need to. But in-line the CSS in the index.html file so that it loads as fast as possible. 🐎

@LuchoTurtle given your recent experience with this, want to pick this one up? 👌
Please drop a comment to confirm that this task is clear or to seek further clarification. 💬
For now we only need this for the Flutter Web version. 📱
We can re-assess for the iOS and Android when the time comes to ship these to the respective App Stores. 💭

@nelsonic nelsonic added help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes. needs-ui A feature idea that needs UI in order to be discussed/built. good first issue flutter Flutter related issues labels Mar 1, 2023
@nelsonic nelsonic added the T2h Time Estimate 2 Hours label Mar 1, 2023
@LuchoTurtle
Copy link
Member

yes 👍 looks clear enough.

@nelsonic
Copy link
Member Author

nelsonic commented Mar 1, 2023

Cool. Please assign PR when ready. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flutter Flutter related issues good first issue help wanted If you can help make progress with this issue, please comment! needs-ui A feature idea that needs UI in order to be discussed/built. priority-1 Highest priority issue. This is costing us money every minute that passes. T2h Time Estimate 2 Hours
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants