Users + Code coverage & CI (minus coverage files) #26
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 5
Lines ? 14
Branches ? 0
=======================================
Hits ? 14
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
| @@ -22,3 +22,6 @@ erl_crash.dump | |||
| # secrets file as long as you replace its contents by environment | |||
| # variables. | |||
| /config/prod.secret.exs | |||
|
|
|||
| # Coverage | |||
| cover | |||
There was a problem hiding this comment.
thanks for ignoring the directory. 👍
| @@ -37,7 +42,9 @@ defmodule Feedback.Mixfile do | |||
| {:phoenix_html, "~> 2.6"}, | |||
| {:phoenix_live_reload, "~> 1.0", only: :dev}, | |||
| {:gettext, "~> 0.11"}, | |||
| {:cowboy, "~> 1.0"}] | |||
| {:cowboy, "~> 1.0"}, | |||
| {:comeonin, "~> 2.0"}, | |||
There was a problem hiding this comment.
we only need comeonin if we are actually letting people save a password, which isn't the case yet, right? 🤔
From what I can tell, this PR does not include a form to actually allow a user to register...
There was a problem hiding this comment.
@nelsonic we'll need it for a user to log in because we require the checkpw function it provides
There was a problem hiding this comment.
here's where we're using it in a subsequent PR https://github.com/dwyl/feedback/pull/33/files#diff-651f440688d3528ab409efd7e368c15fR37 (bit pre-emptive of me)
ready for review
adds changes from Users + Code coverage & CI #24 and removes coverage files People #23
adds users table to ecto People #23 relates to Privacy of Feedback #9 + Authentication - login to receive feedback #21
adds coverage Travis CI + CodeCov #17