Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users + Code coverage & CI #24

Closed
wants to merge 4 commits into from
Closed

Users + Code coverage & CI #24

wants to merge 4 commits into from

Conversation

jackcarlisle
Copy link
Member

@jackcarlisle jackcarlisle commented Apr 5, 2017

ready for review

@jackcarlisle jackcarlisle changed the title Users Users + Code coverage & CI Apr 5, 2017
@jackcarlisle jackcarlisle mentioned this pull request Apr 5, 2017
1 task
@codecov-io
Copy link

codecov-io commented Apr 5, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@5a68388). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #24   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      5           
  Lines             ?     14           
  Branches          ?      0           
=======================================
  Hits              ?     14           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
web/router.ex 100% <ø> (ø)
web/models/user.ex 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a68388...2ebd793. Read the comment docs.

@jackcarlisle jackcarlisle removed the request for review from nelsonic April 5, 2017 22:22
@jackcarlisle jackcarlisle changed the title Users + Code coverage & CI [WiP] Users + Code coverage & CI Apr 5, 2017
@jackcarlisle jackcarlisle changed the title [WiP] Users + Code coverage & CI Users + Code coverage & CI Apr 5, 2017
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackcarlisle we don't usually add coverage files to the repo as they have "high churn" ...
Please add the /coverage folder to .gitignore and let codecov handle the coverage tracking instead of GitHub. Thanks.

@jackcarlisle
Copy link
Member Author

Closing as changes superseded by #26

@jackcarlisle jackcarlisle deleted the users branch April 6, 2017 14:06
@jackcarlisle
Copy link
Member Author

@nelsonic moved to #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants