Specialized dwave samplers #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
randomir
force-pushed
the
specialized-dwave-samplers
branch
from
bbe5e23 to
17c125e
Compare
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
==========================================
- Coverage 92.48% 91.16% -1.33%
==========================================
Files 22 22
Lines 1184 1188 +4
==========================================
- Hits 1095 1083 -12
- Misses 89 105 +16
Continue to review full report at Codecov.
|
randomir
force-pushed
the
specialized-dwave-samplers
branch
from
17c125e to
55060c7
Compare
This was referenced Sep 2, 2020
Merged
randomir
force-pushed
the
specialized-dwave-samplers
branch
2 times, most recently
from
cd6bd2e to
d1732c9
Compare
Addresses dwavesystems#288. Note: breaks backwards compatibility by changing the default value for `client` from `base`/undefined to `qpu`.
Deprecated in favor of `order_by` as part of `solver` definition dict. Introduced in dwavesystems#313, released in 0.9.9. Induces version 0.10.0.
Deprecated since ~ 2018-12.
randomir
force-pushed
the
specialized-dwave-samplers
branch
from
d1732c9 to
337d80a
Compare
arcondello
approved these changes
Sep 22, 2020
| import time | ||
| import functools |
There was a problem hiding this comment.
I do alphabetical, you do by size 😆
randomir
added a commit
to randomir/dwave-system
that referenced
this pull request
Sep 7, 2021
Constrain client type to hybrid, but propagate user-specified solver definition (from config file/env/kwargs). This is a hybrid analogue of dwavesystems#317 (where we applied the same fix to QPU samplers). Note: partial user-supplied solver definition (patch) is not possible. User-supplied solver mapping will not be updated to fix accepted problems types (bqm/dqm) or version preference. Fixes dwavesystems#363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #288.
Closes #335.
(A) and (B) have been implemented, (C) has been dropped for now.
The idea is to have
DWaveSampler/DWaveCliqueSamplerandLeapHybridSamplerauto-select QPU and Hybrid solvers, but allow for user override from a configuration file/environment viasolverparameter.order_byhere, after a client with fix for Alloworder_byto be part of solver definition dict, again dwave-cloud-client#407 is released.