Legacy cleanup for 0.8.0 #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomir
force-pushed
the
legacy-cleanup-for-0.8.0
branch
from
a55d58a to
569d527
Compare
randomir
force-pushed
the
legacy-cleanup-for-0.8.0
branch
from
569d527 to
dc57ba2
Compare
randomir
force-pushed
the
legacy-cleanup-for-0.8.0
branch
from
302d105 to
76de3ba
Compare
Schedule for removal in 0.10.0+
JoelPasvolsky
approved these changes
Sep 8, 2020
|
What about adding dwavesystems/dwave-ocean-sdk#74 to this legacy cleanup? It shouldn't add much work? |
JoelPasvolsky
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Mind also changing https://raw.githubusercontent.com/dwavesystems/dwave-cloud-client/master/docs/index.rst
- Ocean Glossary https://docs.ocean.dwavesys.com/en/latest/glossary.html
to link to https://docs.ocean.dwavesys.com/en/stable/concepts/index.html instead? The other is broken.
Thanks!
arcondello
reviewed
Sep 14, 2020
| # This now the preferred way of BQM binary serialization. | ||
|
|
||
| # XXX: temporary implemented here, until something like | ||
| # dwavesystems/dimod#599 is available. |
There was a problem hiding this comment.
dwavesystems/dimod#599 linking the github issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things, all under legacy-cleanup umbrella. We:
.dwrcconfig file support,Client.solvers(),Solver.is_{qpu,*},Future.occurrences,"samples"and"occurrences"keys inFuture.result(),bqm-refforref, dropbq-zlibet al encoders,dwave.cloud.utils.aliasdictto enabledictkey deprecation warnings,Future.result()return type fromdictto thealiasdictsubclass (should be a drop-in replacement, but heads-up).I plan to release 0.8.0 soon after merging this, which will simplify work on #425, and then dwavesystems/dwave-system#317.
Closes #138.