Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow load method to work on registered model types #841

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Allow load method to work on registered model types #841

merged 1 commit into from
Jun 11, 2021

Conversation

arcondello
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021 •
edited
Loading

Codecov Report

Merging #841 (1c2291c) into main (a4bca10) will increase coverage by 0.02%.
The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   88.26%   88.29%   +0.02%     
==========================================
  Files          70       70              
  Lines        5862     5884      +22     
==========================================
+ Hits         5174     5195      +21     
- Misses        688      689       +1
Impacted Files Coverage Δ
dimod/serialization/fileview.py 87.60% <77.27%> (-2.50%) ⬇️
dimod/binary/binary_quadratic_model.py 88.31% <100.00%> (-0.10%) ⬇️
dimod/discrete/discrete_quadratic_model.py 93.30% <100.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bca10...1c2291c. Read the comment docs.

@arcondello arcondello requested a review from hhtong June 11, 2021 15:03
hhtong
hhtong approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@hhtong hhtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arcondello arcondello merged commit 261546a into dwavesystems:main Jun 11, 2021
@arcondello arcondello deleted the feature/generic-fileview-load branch June 11, 2021 18:13
arcondello added a commit that referenced this pull request Jun 11, 2021
@arcondello
Update version 0.10.0.dev4 -> 0.10.0.dev5
43c5c57 
New Features
------------

* Add `add_bqm` method to C++ BinaryQuadraticModel #821, #823
* Add `Structured.valid_bqm_graph` method for verifying input problem structure #832
* Reimplement `BinaryQuadraticModel` to use new C++ code #828
* `BinaryQuadraticModel` can now be manipulated symbolically #834
* `load` function can now load all model types #841, #843
* `DiscreteQuadraticModel` now has an `.offset` attribute #838
* Add `ConstrainedQuadraticModel` class #839

Fix
---
* Fix type promotions in binary quadratic models with object biases #836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhtong hhtong hhtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arcondello @codecov-commenter @hhtong