check bqm feature first pass #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcondello
reviewed
Jun 2, 2021
arcondello
reviewed
Jun 2, 2021
randomir
reviewed
Jun 2, 2021
Codecov Report
@@ Coverage Diff @@
## main #832 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 63 63
Lines 4652 4654 +2
=======================================
+ Hits 4286 4288 +2
Misses 366 366
Continue to review full report at Codecov.
|
arcondello
approved these changes
Jun 2, 2021
arcondello
added a commit
that referenced
this pull request
Jun 11, 2021
New Features ------------ * Add `add_bqm` method to C++ BinaryQuadraticModel #821, #823 * Add `Structured.valid_bqm_graph` method for verifying input problem structure #832 * Reimplement `BinaryQuadraticModel` to use new C++ code #828 * `BinaryQuadraticModel` can now be manipulated symbolically #834 * `load` function can now load all model types #841, #843 * `DiscreteQuadraticModel` now has an `.offset` attribute #838 * Add `ConstrainedQuadraticModel` class #839 Fix --- * Fix type promotions in binary quadratic models with object biases #836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feels a little clunky, reviews appreciated :)
Closes #830