-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test add optimism airdrop addresses #1516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question otherwise lgtm
dbt_project.yml
Outdated
@@ -28,6 +28,12 @@ models: | |||
ens: | |||
+schema: ens | |||
+materialized: view | |||
airdrop: | |||
+schema: airdrop | |||
+materialized: view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and below should be table
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aalan3 oh right, I just enforced it directly in the model but you're right, it's safer to have it by default here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good now
@chuxinh @MSilb7 In this PR, I experimented with the airdrop optimism addresses table to improve submissions of big/static tables into V2. It turns out materializing it as tables and following the format I used here works well. @chuxinh could you use the same format for the other tables you wanted to add here #1509 ? @MSilb7 Can you check and lmk if I can delete the old airdrop table and keep this one instead ? |
Brief comments on the purpose of your changes:
For Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Join logic:
Incremental logic: