-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ovm1
data UI
#1509
Enable ovm1
data UI
#1509
Conversation
Workflow run id 2996658084 approved. |
Also would like to know if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chuxinh, thanks for your submission. It seems like you're are trying to expose tables that don't exist on Dune v2 ?
(if if does exist and I missed it, could you send me the links of where the table are in the spellbook github repo please ? https://github.com/duneanalytics/spellbook)
Thanks @soispoke! |
Oh alright, let me get back to you quickly on these ones then, I think we need to find a better way to have these tables deployed/exposed somehow. |
@chuxinh I think one good way to do this would be to turn these .csv files into static tables that can be seen, modified and exposed easily on spellbook. A good example of this format is tokens here: https://github.com/duneanalytics/spellbook/blob/main/models/tokens/ethereum/tokens_ethereum_erc20.sql What do you think ? |
Thanks for getting back on this! Yea originally Jeff and Antonio helped on this and uploaded as CSVs. |
Yes ofc, what would be super useful is to transform those csv files into static SQL tables as I mentioned (in this PR for example), and then I can polish everything up, make sure schemas are right and tables are exposed properly. But since I don't have access to the original files rn, I still need you to reformat/resubmit those files as tables if that's ok? |
Thank you!! |
Oh thanks for pointing out where the original files are. Ok yeah I remember something like this. Meghan is OOO but how about we try to go through the process for 1 file so you're not spending too much time on this (maybe with the biggest file ?), and if everything goes well we just do the same for all the other ones. |
Right, I will leave this one open for now and create a separate one and see how it goes |
sounds great thanks ! |
Add
ovm1
to explorer UIFor Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Join logic:
Incremental logic: