Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: The API [GET /uiObject/{oid}/getBounds] returns the view's bounds property. #28

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix: The API [GET /uiObject/{oid}/getBounds] returns the view's bounds property. #28

merged 1 commit into from
Jul 16, 2024

Conversation

yuancjun
Copy link
Contributor

Expected response:

{"bottom":518,"left":925,"right":1009,"top":481}

Actual response:

{"bottom":518,"left":481,"right":1009,"top":925}

The value of the left boundary and the value of the top boundary are swapped.

dtmilano
dtmilano approved these changes Jul 16, 2024
View reviewed changes
Copy link
Owner

@dtmilano dtmilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are totally right https://developer.android.com/reference/android/graphics/Rect#Rect(int,%20int,%20int,%20int)

@dtmilano dtmilano merged commit e491844 into dtmilano:master Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtmilano dtmilano dtmilano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuancjun @dtmilano