Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot new CRPS_EMP_FAIR stat #421

Closed
21 tasks
TatianaBurek opened this issue Oct 6, 2022 · 7 comments · Fixed by #435
Closed
21 tasks

plot new CRPS_EMP_FAIR stat #421

TatianaBurek opened this issue Oct 6, 2022 · 7 comments · Fixed by #435
Assignees
Labels
priority: blocker Blocker requestor: METplus Team METplus Development Team requestor: UK Met Office United Kingdom Met Office required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing

Comments

@TatianaBurek
Copy link
Collaborator

TatianaBurek commented Oct 6, 2022

Describe the Enhancement

MET development version 11.0.0-beta3 made several changes to the "stat" output.

Include CRPS_EMP_FAIR to plotting as a simple stat and agg stat
issues:
dtcenter/METdataio#119
dtcenter/METcalcpy#215

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2799991

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@TatianaBurek TatianaBurek added type: enhancement Improve something that it is currently doing priority: blocker Blocker alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project labels Oct 6, 2022
@TatianaBurek TatianaBurek self-assigned this Oct 6, 2022
@TatianaBurek TatianaBurek added this to the METviewer-5.0 milestone Oct 6, 2022
@TaraJensen TaraJensen added requestor: UK Met Office United Kingdom Met Office and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Oct 20, 2022
@TatianaBurek
Copy link
Collaborator Author

@JohnHalleyGotway Can this statistic be calculated using agg logic? If yes, what is the formula?

@JohnHalleyGotway
Copy link
Contributor

JohnHalleyGotway commented Nov 1, 2022

@TatianaBurek, as seen on this line of code, just like CRPS_EMP, the CRPS_EMP_FAIR statistics is aggregated as a weighted mean, where the weight is defined by the number of matched pairs listed in the TOTAL column.

@TatianaBurek
Copy link
Collaborator Author

@JohnHalleyGotway @venitahagerty I am confused. Which statistics do we need
crps_emp_fair or crpss_emp_fair?
crpss_emp_fair was added to the ECNT table:
https://github.com/dtcenter/METdataio/blob/3d1071619532be5daee3b503bb93af2fe55b4429/METdbLoad/sql/mv_mysql.sql#L452

@JohnHalleyGotway
Copy link
Contributor

JohnHalleyGotway commented Nov 2, 2022

@TatianaBurek, yes, I see why you'd be confused. I think @venitahagerty accidentally added an extra 'S' in the statistic that she added to the database. The new statistics is named CRPS_EMP_FAIR with only one 'S'.

For reference, here are the related issues:

And I do see a copy/paste error in the description in the MET User's Guide that likely caused the confusion. The ECNT Table describes it as:

The Continuous Ranked Probability Skill Score (empirical distribution) adjusted by subtracting 1/2(m) times the mean absolute difference of the ensemble members (m is the ensemble size)

I'll remove the word Skill from that description.

So @venitahagerty can you please update METdataio to correctly store this statistic as CRPS_EMP_FAIR?

@venitahagerty
Copy link
Contributor

venitahagerty commented Nov 2, 2022 via email

@TatianaBurek
Copy link
Collaborator Author

@venitahagerty I don't see this change in develop... Did you do "push"

@venitahagerty
Copy link
Contributor

venitahagerty commented Nov 2, 2022 via email

@TatianaBurek TatianaBurek moved this from Backlog to In Progress in METplus-Analysis-5.0-beta5 (11/21/22) Nov 2, 2022
TatianaBurek added a commit that referenced this issue Nov 2, 2022
@TatianaBurek TatianaBurek linked a pull request Nov 2, 2022 that will close this issue
13 tasks
@TatianaBurek TatianaBurek moved this from In Progress to Pull Request in METplus-Analysis-5.0-beta5 (11/21/22) Nov 2, 2022
TatianaBurek added a commit that referenced this issue Nov 4, 2022
@TatianaBurek TatianaBurek moved this from Pull Request to Done in METplus-Analysis-5.0-beta5 (11/21/22) Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: blocker Blocker requestor: METplus Team METplus Development Team requestor: UK Met Office United Kingdom Met Office required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants