Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the database schema to handle new columns and line types added to the MET-11.0.0-beta3 output. issue #119 #126

Merged
merged 5 commits into from
Oct 21, 2022

Conversation

venitahagerty
Copy link
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:

    Loaded all sample data successfully after creating database with new version of mv_mysql.sql

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway
Copy link
Contributor

I see that the GHA checks failed on the Compare two databases job. But I do think the error makes sense:

pymysql.err.ProgrammingError: (1146, "Table 'mv_ci_prod.line_data_seeps' doesn't exist")
Error: Process completed with exit code 1.

The old database doesn't contain a table for the new SEEPS line type but the new table does since that's what @venitahagerty added. The new database should also contain a new table for SEEPS_MPR, but I'm guessing the comparison is erroring out before getting to that one.

@TatianaBurek and @venitahagerty, you could consider making the database comparison logic more robust to handle differences in which tables actually exist. But I certainly don't think that this error indicates that there's anything wrong with this PR.

But I defer to @TatianaBurek in giving her final review approval on this PR.

@TatianaBurek
Copy link
Collaborator

@venitahagerty When I started working on including the new stats to METviewer I realized that we need to provide the default value -9999 to crpss_emp_fair. It is needed for the old databases when I ran run the update script.

@venitahagerty venitahagerty merged commit cf3543e into develop Oct 21, 2022
@venitahagerty venitahagerty deleted the feature_119_new_seeps_ecnt branch November 21, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update the database schema to handle new columns and line types added to the MET-11.0.0-beta3 output.
3 participants