Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance METbaseimage to install the YAML Python package #15

Closed
10 of 20 tasks
JohnHalleyGotway opened this issue Nov 7, 2023 · 1 comment · Fixed by #16
Closed
10 of 20 tasks

Enhance METbaseimage to install the YAML Python package #15

JohnHalleyGotway opened this issue Nov 7, 2023 · 1 comment · Fixed by #16
Assignees
Labels
component: testing Software testing issue priority: blocker Blocker requestor: NOAA/other NOAA Laboratory, not otherwise specified type: enhancement Improve something that it is currently doing

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Nov 7, 2023

Describe the Enhancement

dtcenter/MET#2550 adds new dependency on the YAML Python package. The TC-Diag tool calls newly added Python diagnostics code which require YAML. This issue is to update METbaseimage to install YAML.

Recommend combining this change with #13 to create a single new tagged version of METbaseimage.

Time Estimate

1 hour

Sub-Issues

Consider breaking the enhancement down into sub-issues.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2770043

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required: Recommend having @DanielAdriaansen review the PR to keep him aware of Python-related updates.

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway
Copy link
Collaborator Author

Manually built on my laptop using the following commands:

bash
cd /Volumes/d1/projects/METbaseimage/.github/jobs
export GITHUB_WORKSPACE=/Volumes/d1/projects/METbaseimage
export GITHUB_TAG=v3.1
export DOCKERHUB_BASE_REPO=dtcenter/met-base
export DOCKERHUB_UNIT_TEST_REPO=dtcenter/met-base-unit-test
./build_docker_image.sh

Pushed the resulting images to DockerHub for testing with the dtcenter/MET#2728 pull request.

docker push dtcenter/met-base:v3.1
docker push dtcenter/met-base-unit-test:v3.1

Note that these manually created v3.1 images will be replaced by GHA when we actually create the official v3.1 METbaseimage release.

@JohnHalleyGotway JohnHalleyGotway mentioned this issue Nov 7, 2023
13 tasks
@JohnHalleyGotway JohnHalleyGotway moved this from 🔖 Ready to 👀 In review in MET-12.0.0 Development Nov 7, 2023
@JohnHalleyGotway JohnHalleyGotway linked a pull request Nov 7, 2023 that will close this issue
13 tasks
JohnHalleyGotway added a commit that referenced this issue Nov 8, 2023
…was that installing the Python NumPy package without specifying a specific version number. The fix is adding specifing Python package version numbers and also removing the --force-reinstall build option. This version does actually build. However, we still get a warning message about --global-option being deprecated.
JohnHalleyGotway added a commit that referenced this issue Nov 9, 2023
…hich inexpicably just create an output file named '=6.0'. Must be the wrong syntax.
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in MET-12.0.0 Development Nov 10, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Update METbaseimage to install the YAML Python package Enhance METbaseimage to install the YAML Python package Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: testing Software testing issue priority: blocker Blocker requestor: NOAA/other NOAA Laboratory, not otherwise specified type: enhancement Improve something that it is currently doing
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

1 participant