-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance TC-Diag to actually compute and write diagnostics #2550
Comments
As discussed at the TC-Diag project meeting on 9/12/23, we should ideally test with at least 3 input data sources:
|
From @robertdemariacira on 8/17/23: I have a version of the code (v0.5.0) that can now read the provided temp netCDF files and perform diagnostic computations from them: Instructions for how to use the code are included at the bottom of the README. Example configs and a manual test of the code are provided. Let me know if you have any questions. |
@robertdemariacira I've followed the instructions listed in the README file and am trying to figure out how to make a call to the driver code to have it compute diagnostics. I'd like to pass to it a NetCDF file for a single time step and see its output. Can you advise on that? |
Based on TC-Diag meeting on 9/20/23:
|
@JohnHalleyGotway I've updated the tc_diag_driver repo to v0.6.0. It no longer requires the ATCF tech ID to be specified in the config file. You can find an example for how to call the driver here. The text distance to land LUT the code needs (for now) can be downloaded from here. You'll need to update the example config files described in the above readme section to point to the location of the LUT file. |
…ithub.com/robertdemariacira/tc_diag_driver to update the error handling logic.
See the TC-Diag project-wide meeting notes from 10/4/23. Relevant for the TC-Diag tool:
Defines the python config file to be applied to that domain. Will be different for the parent and nest.
Defines which diagnostics computed for this domain should override previously defined diagnostics. The default value of an empty list means that all diagnostics returned from python should be used. |
…python diagnostics config files there.
…running bootstrap on seneca.
@JohnHalleyGotway The v0.7.0 TC Diag Driver code addresses the The I added a config parameter: |
…ion 3.1 to include the yaml Python package.
…is is set in at least 4 spots... wish we could consolidate.
@robertdemariacira I'm wondering about scipy. It's used in the Python code here:
And
I don't think that MET is actually using that SciPy interpolation functionality. I'm wondering if I should add SciPy as a new Python requirement even though MET is not actually using it. Or perhaps I should just comment out or delete the portion of the code that uses it. Any suggestions? |
…liminate the dependency on scipy.
@JohnHalleyGotway I don't think the code you're using should ever make a call to scipy. I could wrap the scipy import in a try/except clause and make it an optional dependency so that you don't need to include it as a dependency for MET. |
@robertdemariacira however you'd like to handle it is fine with me. But yes, I'd prefer not to add a dependency on scipy that we won't actually use. For now, I just modified this version of cyclindrical_grid.py by commenting out the scipy related code. If you do implement a more elegant solution in your tc_diag_driver repo, please let me know, and I'll go grab the updated version. Thanks! |
@JohnHalleyGotway Sounds good. I'll let you know when I have that updated. |
…captured in the make_install.log file.
@JohnHalleyGotway I updated tc_diag_driver to v0.9.0. This version includes diag_lib v0.5.0 which now has Scipy as an optional dependency. I tested the driver in an environment where scipy wasn't installed and it appeared to run without any problems. |
…cludes updating diag_lib to version 0.5.0. This makes the SciPy Python package optional rather than required.
Describe the Enhancement
Review details of the initial development version in #2168.
The initial version of the TC-Diag tool is slated for inclusion in the MET-11.1.0 release. It transforms a configurable list of input gridded data fields into range/azimuth cylindrical coordinates and calls python script to compute diagnostics on the result. If the storm track (i.e. OFCL) differs from the gridded data (i.e. GFS), the center of the storm vortex and the track location may not coincide. This task is to incorporate NHC's vortex removal logic into TC-Diag prior to converting to cylindrical coordinates.
CSU/CIRA will provide the algorithm for doing so.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
None needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
This may impact the METplus wrapper of TC-Diag.
Enhancement Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
The text was updated successfully, but these errors were encountered: