Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2441 develop comp #2458

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Feature 2441 develop comp #2458

merged 1 commit into from
Feb 22, 2023

Conversation

jprestop
Copy link
Collaborator

@jprestop jprestop commented Feb 22, 2023

This is the same PR as Feature 2441 main_v11.0 comp #2444 except for the develop branch.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Installed with the compilation script and install_met_env.acorn_py3.10 on WCOSS2 Acorn.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review files if desired; Ensure all tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [N/A]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [20230227].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone). (They are)
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the MET 11.1.0 milestone Feb 22, 2023
@jprestop jprestop requested a review from j-opatz February 22, 2023 17:34
@jprestop jprestop linked an issue Feb 22, 2023 that may be closed by this pull request
21 tasks
Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR passed all of the automated checks successfully and is approved

@jprestop jprestop merged commit b249c9c into develop Feb 22, 2023
@jprestop jprestop deleted the feature_2441_develop_comp branch February 22, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Modify compilation script to add new variable path to LDFLAGS
2 participants