Bugfix 2383 aeronetv3 (main_v11.0)

[hsoh-u]

Expected Differences

Problem 1. The python utility script, print_pointnc2ascii.py, fails if the MET point observation file contains NaN.

Problem 2. The computed AOD 550, NaN, should not be saved which happens when AOD 440 is -999.00 or AOD 650.

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

Problem 1: the python script

Bad:
python3 /d1/projects/MET/MET_regression/develop/NB20230109/MET-develop/share/met/utility/print_pointnc2ascii.py /d1/personal/hsoh/data/MET-2383/aeronet_v3_concat_big_with_nan.nc

Good:
python3 /d1/personal/hsoh/git/bugfixes/bugfix_2370_aeronetv3_main_v11_0/MET/share/met/utility/print_pointnc2ascii.py /d1/personal/hsoh/data/MET-2383/aeronet_v3_concat_big_with_nan.nc

Problem 2: having NaN at ascii2nc output:
Before:

/d1/projects/MET/MET_regression/develop/NB20230109/MET-develop/bin/ascii2nc /d1/personal/hsoh/data/MET-2383/20221209.lev15.txt 20221209.lev15_bad.nc -format aeronetv3

ncdump 20221209.lev15_bad.nc | grep NaN | wc -l
144

After:

/d1/personal/hsoh/git/bugfixes/bugfix_2370_aeronetv3_main_v11_0/MET/bin/ascii2nc /d1/personal/hsoh/data/MET-2383/20221209.lev15.txt 20221209.lev15.nc -format aeronetv3

ncdump 20221209.lev15.nc | grep NaN | wc -l
0

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• [x ] Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

I ran through the same commands that Howard did and got the same results. Thanks for the detailed paths and commands, @hsoh-u! I approve this request.

[jprestop]

I tested on the files obtained in the following way:

wget --no-check-certificate -q -O 20221204.lev15 "https://aeronet.gsfc.nasa.gov/cgi-bin/print_web_data_v3?year=2022&month=12&day=04&year2=2022&month2=12&day2=04&AOD15=1&AVG=10&if_no_html=1"
wget --no-check-certificate -q -O GSFC_20221204.lev15 "https://aeronet.gsfc.nasa.gov/cgi-bin/print_web_data_v3?site=GSFC&year=2022&month=12&day=04&year2=2022&month2=12&day2=04&AOD15=1&AVG=10&if_no_html=1"

The files produced the expected results. I approve this request.