Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASCII2NC logic for reading AERONET v3 data #2370

Closed
8 of 22 tasks
jprestop opened this issue Dec 6, 2022 · 1 comment · Fixed by #2372 or #2376
Closed
8 of 22 tasks

Fix ASCII2NC logic for reading AERONET v3 data #2370

jprestop opened this issue Dec 6, 2022 · 1 comment · Fixed by #2372 or #2376
Assignees
Labels
component: user support User support issue MET: PreProcessing Tools (Point) priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: bug Fix something that is not working
Milestone

Comments

@jprestop
Copy link
Collaborator

jprestop commented Dec 6, 2022

Describe the Problem

This issue arose with the METplus Discussion dtcenter/METplus#1888. When the user obtained AERONET version 3 data from the official site it was determined that the format was not consistent with the format of the data we currently use for our unit testing. Sample files from the new format and @hsoh-u's analysis of what would need to be done for this issue can be viewed within the Discussion at this post.

Expected Behavior

The MET code should be able to read AERONET v3 data obtained from the official site.

Environment

Describe your runtime environment:
1. Machine: not specific
2. OS: not specific
3. Software version number: all current releases

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp
Review the log file from Partha and read the data files he provided.

Relevant Deadlines

MET-11.0.0 Official Release (12/7 - 12/9)

Funding Source

2773542

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@jprestop jprestop added type: bug Fix something that is not working component: user support User support issue requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED ACCOUNT KEY Need to assign an account key to this issue required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone MET: PreProcessing Tools (Point) priority: high High Priority labels Dec 6, 2022
@jprestop jprestop added this to the MET 11.0.0 milestone Dec 6, 2022
@TaraJensen TaraJensen added reporting: DTC NOAA R2O NOAA Research to Operations DTC Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Dec 6, 2022
@hsoh-u hsoh-u moved this from To Do to In Progress in MET-11.0.0 Pre-Release (12/9/22) Dec 6, 2022
hsoh-u pushed a commit that referenced this issue Dec 7, 2022
hsoh-u pushed a commit that referenced this issue Dec 7, 2022
@hsoh-u hsoh-u linked a pull request Dec 7, 2022 that will close this issue
15 tasks
@hsoh-u hsoh-u moved this from In Progress to Pull Request Review in MET-11.0.0 Pre-Release (12/9/22) Dec 7, 2022
@JohnHalleyGotway
Copy link
Collaborator

@hsoh-u please prioritize fixing this in the develop branch to be included in the MET version 11.0.0 release. Once it's fixed there, please port that fix over to the main_v10.1 branch. And we'll include it in any future MET-10.1 bugfix releases.

hsoh-u pushed a commit that referenced this issue Dec 7, 2022
hsoh-u pushed a commit that referenced this issue Dec 7, 2022
@hsoh-u hsoh-u closed this as completed Dec 9, 2022
Repository owner moved this from Pull Request Review to Done in MET-11.0.0 Pre-Release (12/9/22) Dec 9, 2022
Repository owner moved this from To do to Done in Coordinated METplus-4.1 Support Dec 9, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Fix logic in reading AERONET v3 data Fix ascii2nc logic for reading AERONET v3 data Dec 9, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Fix ascii2nc logic for reading AERONET v3 data Fix ASCII2NC logic for reading AERONET v3 data Dec 9, 2022
@JohnHalleyGotway JohnHalleyGotway linked a pull request Dec 12, 2022 that will close this issue
hsoh-u pushed a commit that referenced this issue Jan 10, 2023
hsoh-u pushed a commit that referenced this issue Jan 10, 2023
… Checking inputs at angstrom_power_interplation
@hsoh-u hsoh-u linked a pull request Jan 10, 2023 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: user support User support issue MET: PreProcessing Tools (Point) priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: bug Fix something that is not working
Projects
No open projects
4 participants