Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the MET User's Guide to specify the data types in each output line type table #3032

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Dec 7, 2024 · 4 comments · Fixed by #3040 or #3041
Closed
8 of 21 tasks
Assignees
Labels
component: documentation Documentation issue priority: medium Medium Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/GSL NOAA Global Systems Laboratory type: task An actionable item of work
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Dec 7, 2024

Describe the Task

As requested by @randytpierce via an email to @JohnHalleyGotway on Dec 5, 2024, update the MET User's Guide to add a new column to the output line type tables to indicate the data type. Basically, indicate whether each output column contains an integer, float, or string. This information makes it clear and obvious to users how the data from each output column should be parsed.

Time Estimate

4 hours? -- if this strays more than a day, please contact @michelleharrold

Sub-Issues

Consider breaking the task down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2782544 (NOAA Base)

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a MET-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a MET-X.Y.Z version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added component: documentation Documentation issue type: task An actionable item of work priority: medium Medium Priority requestor: NOAA/GSL NOAA Global Systems Laboratory alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Dec 7, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.0.0 milestone Dec 7, 2024
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in MET-12.0.0 Development Dec 7, 2024
@JohnHalleyGotway JohnHalleyGotway self-assigned this Dec 7, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Update the User's Guide to add the data type for each output line type table Update the User's Guide to add the data type to each output line type table Dec 7, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Update the User's Guide to add the data type to each output line type table Update the User's Guide to specify the data types in each output line type table Dec 7, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Update the User's Guide to specify the data types in each output line type table Update the MET User's Guide to specify the data types in each output line type table Dec 7, 2024
@JohnHalleyGotway
Copy link
Collaborator Author

@michelleharrold can you please advise on this issue? It's currently in "Needs Triage" state. Do we have funding to support these changes to include them in the official MET-12.0.0 release, currently slated for next Wednesday, Dec 18, 2024?

@michelleharrold michelleharrold added reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Dec 12, 2024
@michelleharrold
Copy link

@JohnHalleyGotway -- I added a key. If this starts to stray too far from the estimated time, please lmk! Thanks!

@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🎯 Up Next in MET-12.0.0 Development Dec 17, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🎯 Up Next to 🏗 In progress in MET-12.0.0 Development Dec 17, 2024
@JohnHalleyGotway
Copy link
Collaborator Author

JohnHalleyGotway commented Dec 17, 2024

@randytpierce, I'm going to work on these documentation updates today. Starting with this table and modifying the subsequent line type ones, my plan is to add a new Data Type column to the right side of the table. The value for each row of the table will be:

  • "String" for character strings
  • "Datetime String" for character strings formatted as YYYYMMDD[_YY[MMDD]]
  • "Threshold String" for formatted threshold strings like >35
  • "Integer" for all integer numbers
  • "Double" for all double-precision numbers

I compared to the contents of the METdataio schema which does include details like maximum string length (e.g. model VARCHAR(80)) and signed vs unsigned integers (e.g. interp_pnts INT UNSIGNED). I do NOT think that level of detail is warranted here. MET doesn't actually limit the length of the model string. It's the database that does.

Just wanted to check with you to confirm that this level of detail meets your needs. Were you looking for anything in addition to or other than this?

@randytpierce
Copy link

randytpierce commented Dec 17, 2024 via email

JohnHalleyGotway added a commit that referenced this issue Dec 18, 2024
… is repeated from the table name. Additional changes for consistency and accuracy in column names.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Dec 18, 2024 that will close this issue
17 tasks
JohnHalleyGotway added a commit that referenced this issue Dec 18, 2024
… is repeated from the table name. Additional changes for consistency and accuracy in column names.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Dec 18, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in MET-12.1.0 Development Dec 18, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🔎 In review in MET-12.1.0 Development Dec 18, 2024
JohnHalleyGotway added a commit that referenced this issue Dec 18, 2024
* Per #3032, add data type column to all of the output tables

* Per #3032, remove the first row from each output table since its info is repeated from the table name. Additional changes for consistency and accuracy in column names.

* Update docs/Users_Guide/gsi-tools.rst

Co-authored-by: Julie Prestopnik <[email protected]>

---------

Co-authored-by: Julie Prestopnik <[email protected]>
JohnHalleyGotway added a commit that referenced this issue Dec 18, 2024
* Per #3032, add data type column to all of the output tables

* Per #3032, remove the first row from each output table since its info is repeated from the table name. Additional changes for consistency and accuracy in column names.

* Update docs/Users_Guide/gsi-tools.rst

Co-authored-by: Julie Prestopnik <[email protected]>

---------

Co-authored-by: Julie Prestopnik <[email protected]>
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in MET-12.1.0 Development Dec 18, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 🏁 Done in MET-12.0.0 Development Dec 18, 2024
JohnHalleyGotway added a commit that referenced this issue Dec 19, 2024
* use custom GitHub Action to trigger METplus use cases

* Updating values

* Bugfix #3020 main_v12.0 grid_stat_seeps (#3022)

* Per #3020, add missing GridStatNcOutInfo::do_seeps flag and use it to determine if SEEPS information should be written to the Grid-Stat NetCDF matched pairs output file.

* Unrelated to #3020, fix broken NetCDF cf-conventions links in the User's Guide.

* Per #3020, no real changes. Just whitespace

* Update to reflect usage of oneAPI compilers

* Updating file to reflect usage of oneAPI compilers

* Hotfix to the main_v12.0 branch after PR #3022 fixed a SEEPS bug. The GridStatConfig_SEEPS config file needs to be updated with nc_pairs_flag.seeps = TRUE in order for the same output to be produced by the unit tests.

* Adding In Memoriam

* Feature #3032 main_v12.0 docs data type (#3040)

* Per #3032, add data type column to all of the output tables

* Per #3032, remove the first row from each output table since its info is repeated from the table name. Additional changes for consistency and accuracy in column names.

* Update docs/Users_Guide/gsi-tools.rst

Co-authored-by: Julie Prestopnik <[email protected]>

---------

Co-authored-by: Julie Prestopnik <[email protected]>

* Making a superficial change in the main_v12.0 branch to trigger GHA to create and push an updated test output image.

---------

Co-authored-by: George McCabe <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue priority: medium Medium Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/GSL NOAA Global Systems Laboratory type: task An actionable item of work
Projects
Status: 🏁 Done
Status: 🏁 Done
3 participants