-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the MET User's Guide to specify the data types in each output line type table #3032
Comments
@michelleharrold can you please advise on this issue? It's currently in "Needs Triage" state. Do we have funding to support these changes to include them in the official MET-12.0.0 release, currently slated for next Wednesday, Dec 18, 2024? |
@JohnHalleyGotway -- I added a key. If this starts to stray too far from the estimated time, please lmk! Thanks! |
@randytpierce, I'm going to work on these documentation updates today. Starting with this table and modifying the subsequent line type ones, my plan is to add a new
I compared to the contents of the METdataio schema which does include details like maximum string length (e.g. Just wanted to check with you to confirm that this level of detail meets your needs. Were you looking for anything in addition to or other than this? |
This sounds wonderful, actually!
thanks,
randy
…On Tue, Dec 17, 2024 at 11:50 AM John Halley Gotway < ***@***.***> wrote:
@randytpierce <https://github.com/randytpierce>, I'm going to work on
these documentation updates today. Starting with this table
<https://met.readthedocs.io/en/main_v12.0/Users_Guide/point-stat.html#id5>
and modifying the subsequent line type ones, my plan is to add a new Data
Type column to the right side of the table. The value for each column
will be:
- "String" for character strings
- "Datetime String" for character strings formatted as
YYYYMMDD[_YY[MMDD]]
- "Threshold String" for formatted threshold strings like >35
- "Integer" for all integer numbers
- "Double" for all double-precision numbers
I compared to the contents of the METdataio schema
<https://github.com/dtcenter/METdataio/blob/develop/METdbLoad/sql/mv_mysql.sql>
which does include details like expected string length (e.g. model
VARCHAR(80)) and signed vs unsigned integers (e.g. interp_pnts INT
UNSIGNED). I do NOT think that level of detail is warranted here. MET
doesn't actually limit the length of the model string. It's the database
that does.
Just wanted to check with you to confirm that this level of detail meets
your needs. Or were you looking for anything in addition or other than this?
—
Reply to this email directly, view it on GitHub
<#3032 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGDVQPRAPDW5UUCQUG7GKH32GBW6VAVCNFSM6AAAAABTGNHIVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBZGMZDQMZSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Randy Pierce
|
… is repeated from the table name. Additional changes for consistency and accuracy in column names.
… is repeated from the table name. Additional changes for consistency and accuracy in column names.
* Per #3032, add data type column to all of the output tables * Per #3032, remove the first row from each output table since its info is repeated from the table name. Additional changes for consistency and accuracy in column names. * Update docs/Users_Guide/gsi-tools.rst Co-authored-by: Julie Prestopnik <[email protected]> --------- Co-authored-by: Julie Prestopnik <[email protected]>
* Per #3032, add data type column to all of the output tables * Per #3032, remove the first row from each output table since its info is repeated from the table name. Additional changes for consistency and accuracy in column names. * Update docs/Users_Guide/gsi-tools.rst Co-authored-by: Julie Prestopnik <[email protected]> --------- Co-authored-by: Julie Prestopnik <[email protected]>
* use custom GitHub Action to trigger METplus use cases * Updating values * Bugfix #3020 main_v12.0 grid_stat_seeps (#3022) * Per #3020, add missing GridStatNcOutInfo::do_seeps flag and use it to determine if SEEPS information should be written to the Grid-Stat NetCDF matched pairs output file. * Unrelated to #3020, fix broken NetCDF cf-conventions links in the User's Guide. * Per #3020, no real changes. Just whitespace * Update to reflect usage of oneAPI compilers * Updating file to reflect usage of oneAPI compilers * Hotfix to the main_v12.0 branch after PR #3022 fixed a SEEPS bug. The GridStatConfig_SEEPS config file needs to be updated with nc_pairs_flag.seeps = TRUE in order for the same output to be produced by the unit tests. * Adding In Memoriam * Feature #3032 main_v12.0 docs data type (#3040) * Per #3032, add data type column to all of the output tables * Per #3032, remove the first row from each output table since its info is repeated from the table name. Additional changes for consistency and accuracy in column names. * Update docs/Users_Guide/gsi-tools.rst Co-authored-by: Julie Prestopnik <[email protected]> --------- Co-authored-by: Julie Prestopnik <[email protected]> * Making a superficial change in the main_v12.0 branch to trigger GHA to create and push an updated test output image. --------- Co-authored-by: George McCabe <[email protected]> Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: John Halley Gotway <[email protected]>
Describe the Task
As requested by @randytpierce via an email to @JohnHalleyGotway on Dec 5, 2024, update the MET User's Guide to add a new column to the output line type tables to indicate the data type. Basically, indicate whether each output column contains an integer, float, or string. This information makes it clear and obvious to users how the data from each output column should be parsed.
Time Estimate
4 hours? -- if this strays more than a day, please contact @michelleharrold
Sub-Issues
Consider breaking the task down into sub-issues.
None needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2782544 (NOAA Base)
Define the Metadata
Assignee
Labels
Milestone and Projects
Define Related Issue(s)
Consider the impact to the other METplus components.
Task Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: MET-X.Y.Z Development project for development toward the next official release
The text was updated successfully, but these errors were encountered: