Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Fix Grid-Stat segfault when SEEPS is the only NetCDF output type requested #3020

Closed
10 of 23 tasks
JohnHalleyGotway opened this issue Nov 15, 2024 · 0 comments · Fixed by #3021 or #3022
Closed
10 of 23 tasks

Bugfix: Fix Grid-Stat segfault when SEEPS is the only NetCDF output type requested #3020

JohnHalleyGotway opened this issue Nov 15, 2024 · 0 comments · Fixed by #3021 or #3022
Assignees
@JohnHalleyGotway @j-opatz
Labels
MET: Grid-to-Grid Verification priority: high High Priority requestor: UK Met Office United Kingdom Met Office type: bug Fix something that is not working
Milestone
MET-12.0.0

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Nov 15, 2024 •
edited
Loading

Describe the Problem

As described in discussion dtcenter/METplus#2794, Grid-Stat segfaults when SEEPS is the only NetCDF output type requested. Grid-Stat attempts to write the SEEPS data to the NetCDF output file prior to that file being created.

Remember to fix this in both the develop and main_v12.0 branches.

Expected Behavior

This issue is to update the Grid-Stat logic to create and initialize the NetCDF output file, even if SEEPS is the only type requested.

Environment

Describe your runtime environment:

  • Identified by the MetOffice and replicated on seneca.

To Reproduce

Describe the steps to reproduce the behavior:

Relevant Deadlines

Include fix in the MET-12.0.0 release.

Funding Source

2799991

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select MET-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working requestor: UK Met Office United Kingdom Met Office alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Grid-to-Grid Verification priority: high High Priority labels Nov 15, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.0.0 milestone Nov 15, 2024
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in MET-12.0.0 Development Nov 15, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🏗 In progress in MET-12.0.0 Development Nov 15, 2024
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Nov 15, 2024
JohnHalleyGotway added a commit that referenced this issue Nov 15, 2024
@JohnHalleyGotway
Per #3020, add missing GridStatNcOutInfo::do_seeps flag and use it to…
a3229ac 
… determine if SEEPS information should be written to the Grid-Stat NetCDF matched pairs output file.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Nov 15, 2024 that will close this issue
Bugfix #3020 develop grid_stat_seeps #3021
Merged
17 tasks
JohnHalleyGotway added a commit that referenced this issue Nov 15, 2024
@JohnHalleyGotway
Per #3020, add missing GridStatNcOutInfo::do_seeps flag and use it to…
ff55db0 
… determine if SEEPS information should be written to the Grid-Stat NetCDF matched pairs output file.
JohnHalleyGotway added a commit that referenced this issue Nov 15, 2024
@JohnHalleyGotway
Unrelated to #3020, fix broken NetCDF cf-conventions links in the Use…
50d81f8 
…r's Guide.
JohnHalleyGotway added a commit that referenced this issue Nov 15, 2024
@JohnHalleyGotway
Unrelated to #3020, fix broken NetCDF cf-conventions links in the Use…
4aba119 
…r's Guide.
JohnHalleyGotway added a commit that referenced this issue Nov 15, 2024
@JohnHalleyGotway
Per #3020, no real changes. Just whitespace
02db6ae
JohnHalleyGotway added a commit that referenced this issue Nov 15, 2024
@JohnHalleyGotway
Per #3020, no real changes. Just whitespace
278b21a
@JohnHalleyGotway JohnHalleyGotway linked a pull request Nov 15, 2024 that will close this issue
Bugfix #3020 main_v12.0 grid_stat_seeps #3022
Merged
@JohnHalleyGotway JohnHalleyGotway moved this from 🏗 In progress to 🔎 In review in MET-12.0.0 Development Nov 15, 2024
JohnHalleyGotway added a commit that referenced this issue Nov 20, 2024
@JohnHalleyGotway
Bugfix #3020 develop grid_stat_seeps (#3021)
80054d2 
* Per #3020, add missing GridStatNcOutInfo::do_seeps flag and use it to determine if SEEPS information should be written to the Grid-Stat NetCDF matched pairs output file.

* Unrelated to #3020, fix broken NetCDF cf-conventions links in the User's Guide.

* Per #3020, no real changes. Just whitespace
JohnHalleyGotway added a commit that referenced this issue Nov 20, 2024
@JohnHalleyGotway
Bugfix #3020 main_v12.0 grid_stat_seeps (#3022)
c691e02 
* Per #3020, add missing GridStatNcOutInfo::do_seeps flag and use it to determine if SEEPS information should be written to the Grid-Stat NetCDF matched pairs output file.

* Unrelated to #3020, fix broken NetCDF cf-conventions links in the User's Guide.

* Per #3020, no real changes. Just whitespace
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in MET-12.0.0 Development Nov 20, 2024
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in MET-12.1.0 Development Dec 18, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🏁 Done in MET-12.1.0 Development Dec 18, 2024
JohnHalleyGotway added a commit that referenced this issue Dec 19, 2024
@github-actions @georgemccabe
@jprestop @JohnHalleyGotway
Update main_v12.0-ref for MET#3042 (#3044)
2e33579 
* use custom GitHub Action to trigger METplus use cases

* Updating values

* Bugfix #3020 main_v12.0 grid_stat_seeps (#3022)

* Per #3020, add missing GridStatNcOutInfo::do_seeps flag and use it to determine if SEEPS information should be written to the Grid-Stat NetCDF matched pairs output file.

* Unrelated to #3020, fix broken NetCDF cf-conventions links in the User's Guide.

* Per #3020, no real changes. Just whitespace

* Update to reflect usage of oneAPI compilers

* Updating file to reflect usage of oneAPI compilers

* Hotfix to the main_v12.0 branch after PR #3022 fixed a SEEPS bug. The GridStatConfig_SEEPS config file needs to be updated with nc_pairs_flag.seeps = TRUE in order for the same output to be produced by the unit tests.

* Adding In Memoriam

* Feature #3032 main_v12.0 docs data type (#3040)

* Per #3032, add data type column to all of the output tables

* Per #3032, remove the first row from each output table since its info is repeated from the table name. Additional changes for consistency and accuracy in column names.

* Update docs/Users_Guide/gsi-tools.rst

Co-authored-by: Julie Prestopnik <[email protected]>

---------

Co-authored-by: Julie Prestopnik <[email protected]>

* Making a superficial change in the main_v12.0 branch to trigger GHA to create and push an updated test output image.

---------

Co-authored-by: George McCabe <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnHalleyGotway JohnHalleyGotway

@j-opatz j-opatz

Labels
MET: Grid-to-Grid Verification priority: high High Priority requestor: UK Met Office United Kingdom Met Office type: bug Fix something that is not working
Projects
MET-12.1.0 Development
Status: 🏁 Done
MET-12.0.0 Development
Status: 🏁 Done
Milestone
MET-12.0.0
2 participants
@JohnHalleyGotway @j-opatz