Skip to content

Commit

Permalink
Partially addresses issue Bears-R-Us#3050, updating PROTO tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
drculhane committed Apr 3, 2024
1 parent 180b7b8 commit 84b4e65
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions PROTO_tests/tests/message_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ def test_reply_msg(self):
class TestJSONArgs:
# TODO numpy dtypes are not supported by json, we probably want to add an issue to handle this
SCALAR_TYPES = [int, float, bool, str]
PDA_TYPES = [ak.dtype(t) for t in ak.DTypes if t != "str"]
# The types below are support in arkouda, as noted in serverConfig.json. This may be
# the same issue noted in the above comment.
SUPPORTED_TYPES = [ak.bool, ak.uint64, ak.int64, ak.bigint, ak.uint8, ak.float64]

@pytest.mark.parametrize("dtype", SCALAR_TYPES)
def test_scalar_args(self, dtype):
Expand Down Expand Up @@ -204,7 +206,7 @@ def test_fields_arg(self):
)
assert args == expected

@pytest.mark.parametrize("dtype", PDA_TYPES)
@pytest.mark.parametrize("dtype", SUPPORTED_TYPES)
def test_pda_arg(self, dtype):
pda1 = ak.arange(3, dtype=dtype)
pda2 = ak.arange(4, dtype=dtype)
Expand Down
6 changes: 4 additions & 2 deletions PROTO_tests/tests/series_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,10 @@ def test_value_counts(self):

def test_concat(self):
s = ak.Series(ak.arange(5))
s2 = ak.Series(ak.arange(5, 11), ak.arange(5, 11))
s3 = ak.Series(ak.arange(5, 10), ak.arange(5, 10))
# added data= and index= clarifiers to the next two lines.
# without them, the index was interpreted as the name.
s2 = ak.Series(data=ak.arange(5, 11), index=ak.arange(5, 11))
s3 = ak.Series(data=ak.arange(5, 10), index=ak.arange(5, 10))

df = ak.Series.concat([s, s2], axis=1)
assert isinstance(df, ak.DataFrame)
Expand Down

0 comments on commit 84b4e65

Please sign in to comment.