Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PROTO_tests #3050

Closed
9 of 40 tasks
stress-tess opened this issue Mar 19, 2024 · 2 comments
Closed
9 of 40 tasks

Update PROTO_tests #3050

stress-tess opened this issue Mar 19, 2024 · 2 comments
Assignees
@ajpotts @stress-tess @jaketrookman @drculhane
Milestone
arkouda/tests fol...

Comments

@stress-tess
Copy link
Member

stress-tess commented Mar 19, 2024 •
edited by ajpotts
Loading

Go through the files in PROTO_test and make sure they:

  • cover everything from their associated file in the tests dir does (copy over any non-obvious ones)
  • run and pass

The goal is to add a makefile command for theses and test it in the CI. Eventually we will make these our only tests

If i missed any feel free to add it! To start on one of the tests, click the little circle with a dot on the right hand side (it will say "convert to issue" when you scroll over it). Then add yourself as the assignee and a description to the issue.

When you finish with a test, click the little box beside it to show that the task is complete

If you don't understand what I'm saying feel free to ask :)
@ajpotts ajpotts mentioned this issue Mar 19, 2024
Closed
@stress-tess
Copy link
Member Author

Known failing tests are listed in #2965

@stress-tess stress-tess mentioned this issue Mar 19, 2024
Closed
23 tasks
drculhane added a commit to drculhane/arkouda that referenced this issue Apr 3, 2024
@drculhane
Partially addresses issue Bears-R-Us#3050, updating PROTO tests.
84b4e65
@stress-tess stress-tess mentioned this issue Apr 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 3, 2024
@drculhane
Partially addresses issue #3050, updating PROTO tests. (#3075)
aab2f13 
Co-authored-by: drculhane <[email protected]>
bmcdonald3 pushed a commit to bmcdonald3/arkouda that referenced this issue May 9, 2024
@drculhane @bmcdonald3
Partially addresses issue Bears-R-Us#3050, updating PROTO tests. (Bea…
556b3cc 
…rs-R-Us#3075)

Co-authored-by: drculhane <[email protected]>
@ajpotts
Copy link
Contributor

ajpotts commented Jul 16, 2024

Issues have been moved to the milestone: https://github.com/Bears-R-Us/arkouda/milestone/3
So the parent ticket is no longer necessary.

@ajpotts ajpotts closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajpotts ajpotts

@stress-tess stress-tess

@jaketrookman jaketrookman

@drculhane drculhane

Labels
None yet
Projects
None yet
Milestone
arkouda/tests folder Deprecation
Development

No branches or pull requests
4 participants
@ajpotts @stress-tess @jaketrookman @drculhane