Update PasswordAuth with AuthenticateWithPasswordResultAsync #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasticactions
added a commit
that referenced
this pull request
Dec 27, 2024
* Add missing parameters to getAuthorFeed * Don't set ATError object when logging * Add AspectRatio to ImageView * Start sourcegen * Update * Update Tools * Update * Remove usings, since it's in global * Try again * update * Update * Update * Update * Update * Update * Update * Almost... * Update * Update * Update logging-in.md * Add codeflow to readme * Update... * Expose the Cursor on the NotificationCollection * Almost... maybe... * Firehose * Update * The big one * Update * Update... * Fix Readme * Start refactoring... * More types * More cleanup * More modding... * More types... * Closer... * Nearly... * Fun! * First run! * Tests and More * Add Tests for Endpoints * Add class entries * Trying to generate helpers... * More generated Parameters * And helper methods! * Update Generated Types with less aggressive Null values Also fix JSON ATObject type to allow fallback * Update Docs, bump ATProto again... * Revert... * Revert... * Revert... * Add parameter constructors... * Update docs * More docs * Update docs * Adjust tests (???) * Remove deprecated classes and methods * Remove FishyFlipDX, Replace FishyFlip with Source Gen Bits (#104) +semver: breaking * Add docs, bump to net9.0 (#105) * Add docs, bump to net9.0 * Bump to net9 * Fix ImportRepo, add OpenGraphParser (#106) * Fix ImportRepo * Add OpenGraphParser * Cleanup + Fix WASM support (#108) * Order by classname * Update * small cleanup * Update * Use SupportsAutomaticDecompression for setting AutomaticDecompression, add WASM site back * Add WhiteWind Generator, add GetRecord (#110) * Add ATError Object Generator (#112) * Add Error Generator * Add Possible Errors * Warning cleanup * Add ToString override for ATError (#113) * Fix GetBlob to return byte[] (#114) * Resolve Repo DIDs and Handles independently (#115) * Start refactoring URL * Update * Fix tests * Fix Facet Parsing (#116) * Fix Facet Parsing * Remove DistinctBy * Reintroduce bskycli (#117) * Add bskycli * Image Aspect Ratio * Update * Update * Update readme * Update * Fix Windows script * Bump ATProtocol, Bind ATFile Lexicon support (#118) * Bump atprotocol * Add ATFile support * Add build_binding script (#119) * Update PasswordAuth with AuthenticateWithPasswordResultAsync (#120) * Update PasswordAuth with AuthenticateWithPasswordResultAsync * Really??? * Use public.api.bsky.app for unauthed sessions by default (#121) * Add 2FA Auth Token support for Password Auth (#122) * Bump dependencies (#123) * Add Post helper for PostView (#124) * Bump dependencies (#125) * Resolve users PDS before authentication (#126) * Add Pastesphere support (#127) * Add AniBlue support (#128) * Bump Bindings (#129) * Add community lexicons (#130) * Add DidDoc helpers (#131) * patch: Special case booleans (#132) * Bump bindings (#133) * Override ATUri/ATIdentifier Equals for proper checking (#134) * Bump bindings * Override Equals * Add support for setting Labels / Fixes Chat (#135) * Update SourceGen for Labels * Update for labels * Fix chat too --------- Co-authored-by: Thomas May <[email protected]> Co-authored-by: Kevin Gosse <[email protected]> Co-authored-by: Matt Brailsford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only returning the null
SessionwithAuthenticateWithPasswordAsync, it should return aResult<Session?>instead so you can get access to the error object directly. Before, it was only being surfaced inside of the logger, which may not have been obvious enough a location for it. This would also map to the rest of the APIs when directly talking to the lexicon, so this makes sense to do here.I obsoleted the original
AuthenticateWithPasswordAsyncto make it clear you should useAuthenticateWithPasswordResultAsyncinstead to get the error object.