Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation, I had wrote that you need to get the byte slice to create a facet. For example:
This is "kinda" right (You do need to get the bytes from UTF8, not rely on the default from .NET, and the start index may not represent the actual place in the byte array), but not only is this not totally correct, the helpers I wrote to make them were not using this. They were using Length from the matched Regex. This would break with Unicode/non-ASCII characters.
This should fix it by using spans to pattern match.
To use the new helpers, you can use
Facet.Parse
for a complete string, orFacet.ForMentions
,Facet.ForHashtags
,Facet.ForMentions
for the individual facets.