Fix HelperProxy keyword argument passing for Ruby 3

[tbuehlmann]

It seems Ruby 3 doesn't recognize passed hash arguments as keyword arguments like it did in Ruby 2.7. That's why we need to properly pass keyword arguments.

Fixes #884.

[brian-kephart]

Unfortunately this approach is not backwards compatible with all recent Rubies. There is already a PR #885 that fixes this issue in a backwards-compatible way. It is waiting on moderator approval to merge, but hasn't received attention so far.

More info about argument forwarding in different Ruby versions.

[tbuehlmann]

@brian-kephart: Have an example of a Ruby version that wouldn't work with the fix?

[n-rodriguez]

There is already a PR #885 that fixes this issue in a backwards-compatible way. It is waiting on moderator approval to merge, but hasn't received attention so far.

I don't know which PR works best, but I thinks this (https://travis-ci.org/github/drapergem/draper/jobs/754121898) should be fixed.

And why not merge this (#893) before to have a faster CI.

[tbuehlmann]

@n-rodriguez: Fixed in #895.

[brian-kephart]

@tbuehlmann the compatibility issues are detailed in the article I linked, specifically at this heading: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/#a-compatible-delegation

[tbuehlmann]

Fine with me.

[n-rodriguez]

@tbuehlmann can you please rebase your branch on master? thank you!

[tbuehlmann]

@n-rodriguez: Sure, done.

[n-rodriguez]

Unfortunately this approach is not backwards compatible with all recent Rubies.

I agree. See: https://github.com/drapergem/draper/pull/894/checks

[tbuehlmann]

Fine with me! Let's close this PR then?

[codebycliff]

@tbuehlmann I apologize. Had I been quicker to merge #885, I don't think you would have wasted your time. Either way, your contribution is appreciated. I'm going to close this in favor of the other pull request.

[tbuehlmann]

@codebycliff : Oh don't worry, it's fine.