-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kwargs for Ruby 2.7 #885
Conversation
Apologies, I had the wrong branch checked out when I tested this PR and requested changes. The PR works, and I deleted my earlier comment. Thanks @oieioi! |
This looks good. I apologize for how long it has taken me to getting around to this. Do you want to rebase / update the branch with |
Probably 3.0 should be added to CI here since it's out and fixing kwargs for 2.7 is not that required per se. |
@codebycliff I merged |
@oieioi can you please rebase your branch on master? |
553a09b
to
9080b71
Compare
@n-rodriguez Yes. I rebased and force-pushed it. |
9080b71
to
aa2812a
Compare
@oieioi thank you ! |
@oieioi I've added a commit on top of yours to add Ruby 3 CI : oieioi#1 All is green https://github.com/n-rodriguez/draper/runs/1769538026?check_suite_focus=true 👍 ping @codebycliff |
Also, I think we are good on this, but can someone double-check that this pull request isn't going to cause compatibility issues: https://github.com/drapergem/draper/pull/870/files? |
Since #870 is already in From what I see it looks good to me. |
@n-rodriguez @codebycliff Thank you for oieioi#1. I merged it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone! Sorry for the delay on all this.
Description
Fix kwargs for Ruby 2.7.
References