Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruby 2.7 deprecation #870

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Conversation

badlamer
Copy link
Contributor

@badlamer badlamer commented Jan 7, 2020

Description

Remove ruby 2.7 deprecation

lib/ruby/gems/2.7.0/gems/draper-3.1.0/lib/draper/delegation.rb:10: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

Detail your changes here.
A few sentences describing the overall goals of the pull request's commits will suffice.
Some questions you might answer:

References

Copy link
Collaborator

@codebycliff codebycliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codebycliff codebycliff merged commit 6a3bf0d into drapergem:master Jan 7, 2020
@codebycliff codebycliff mentioned this pull request Jan 7, 2020
@mberlanda
Copy link

hey @codebycliff , would it be possible to bump a minor version with this deprecation warning fixed ? Thanks a lot!

@codebycliff
Copy link
Collaborator

Unfortunately there are breaking changes in master so a quick minor version release won't be possible. I'm hoping to cut a new version in the coming weeks.

@swistaczek
Copy link

Hey, any chance that you know release date @codebycliff :)?

@codebycliff
Copy link
Collaborator

I just got version 4.0.0 released this morning. Please let me know if you have any issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants