Get sysdicloud-values secret #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now if the backend version is higher than 6.5, it should get the sysdigcloud-values secret which include different settings such as JVM etc...
jameslarrea
suggested changes
May 31, 2024
There was a problem hiding this comment.
Thanks @BuenClima! Looks good but the namespace should not be hardcoded because while the default the installer uses is sysdigcloud the customer can use any name. It gets set in the script here
You can see the other kubectl commands for examples.Also, minor but can we name the values file where this data will be stored imported_values.yaml?
mbreitung
reviewed
Jun 3, 2024
jameslarrea
suggested changes
Jun 14, 2024
mbreitung
reviewed
Jun 17, 2024
mbreitung
reviewed
Jun 17, 2024
Co-authored-by: Mark Breitung <[email protected]>
jameslarrea
reviewed
Jun 17, 2024
There was a problem hiding this comment.
the variable $version is not defined. There is an issue with BACKEND_VERSION being fixed here #237
But even then, seems that variable is not global but rather we run it every time we need to check the version. Let me discuss with @dark-vex tomorrow if maybe we can refactor that part a bit so it's cleaner.
mbreitung
previously approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if the backend version is higher than 6.5, it should get the sysdigcloud-values secret which include different settings such as JVM, etc...