-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(support-bundle): Added readme, fix api_url retrieval (for >= 6.9), fixed a regex for detect double digit version #237
Conversation
I have renamed also the PR title |
@patrickhargett @mbreitung could you please take a look at the PR and in case approve or suggesting any change if needed? 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
e6980c2
Hi team, LY is waiting for this release. Can we proceed with this release? Thanks. |
cc1a1b7
…egex Signed-off-by: Daniele De Lorenzi <[email protected]>
Signed-off-by: Daniele De Lorenzi <[email protected]>
Co-authored-by: Mark Breitung <[email protected]>
Co-authored-by: Mark Breitung <[email protected]>
Co-authored-by: Mark Breitung <[email protected]>
Co-authored-by: Mark Breitung <[email protected]>
7049b0d
to
8577da7
Compare
…cript execution Signed-off-by: Daniele De Lorenzi <[email protected]>
…secure API if statement Signed-off-by: Daniele De Lorenzi <[email protected]>
Signed-off-by: Daniele De Lorenzi <[email protected]>
Hi team, thank you for working on this. It worked fine in our lab, but LY got the same error in their environment.
It does not seem to take into account the case where the Registry URL contains a port number, as in their environment.
Can you make a further update to take into account cases where the Registry URL includes a port number, as in their environment? What about determining the version by customerVersion via api as described in this thread? Thanks, |
Added readme for support_bundle workaround for API_URL, fixed API_URL for Backend V6.9 and highers