Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(support-bundle): Added readme, fix api_url retrieval (for >= 6.9), fixed a regex for detect double digit version #237

Merged
merged 10 commits into from
Jul 15, 2024

Conversation

victorbecerragit
Copy link

Added readme for support_bundle workaround for API_URL, fixed API_URL for Backend V6.9 and highers

@dark-vex
Copy link
Contributor

dark-vex commented May 9, 2024

I have removed the additional script and added the flags -la / --local-api that will automatically creates the kubernetes port forward.

While testing the script on a 6.10 and 6.11, I have spotted another bug. Support bundle script is unable to parse versions greater than 6.9 or 5.9, is going to return the error message:

We could not determine the backend version. Exiting.

I have changed the regex in order to fix it, this is what the previous regex was parsing:
Screenshot 2024-05-09 at 10 28 00
Screenshot 2024-05-09 at 10 28 36

dark-vex
dark-vex previously approved these changes May 9, 2024
dark-vex
dark-vex previously approved these changes May 9, 2024
@dark-vex dark-vex changed the title added readme for support_bundle and fix api_url for V6.9 chore(support-bundle): Added readme, fix api_url retrieval (for >= 6.9), fixed a regex for detect double digit version May 10, 2024
@dark-vex
Copy link
Contributor

I have renamed also the PR title

@dark-vex dark-vex requested a review from mbreitung May 10, 2024 10:50
@dark-vex dark-vex requested a review from cristof-ziel June 17, 2024 07:10
cristof-ziel
cristof-ziel previously approved these changes Jun 17, 2024
@dark-vex
Copy link
Contributor

@patrickhargett @mbreitung could you please take a look at the PR and in case approve or suggesting any change if needed? 🙇

patrickhargett
patrickhargett previously approved these changes Jun 24, 2024
Copy link
Contributor

@patrickhargett patrickhargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mbreitung
mbreitung previously approved these changes Jun 25, 2024
@dark-vex dark-vex dismissed stale reviews from mbreitung, patrickhargett, cristof-ziel, and themself via e6980c2 June 26, 2024 08:40
cristof-ziel
cristof-ziel previously approved these changes Jun 26, 2024
@amoriroma
Copy link

Hi team, LY is waiting for this release. Can we proceed with this release? Thanks.

@patrickhargett patrickhargett self-requested a review July 3, 2024 12:20
patrickhargett
patrickhargett previously approved these changes Jul 3, 2024
@dark-vex dark-vex dismissed stale reviews from patrickhargett and cristof-ziel via cc1a1b7 July 5, 2024 18:28
@dark-vex dark-vex force-pushed the support-bundle-v6-apiurl-fix branch from 7049b0d to 8577da7 Compare July 10, 2024 07:51
@mbreitung mbreitung enabled auto-merge July 11, 2024 14:48
@mbreitung mbreitung merged commit c6eade3 into master Jul 15, 2024
@mbreitung mbreitung deleted the support-bundle-v6-apiurl-fix branch July 15, 2024 07:13
@amoriroma
Copy link

Hi team, thank you for working on this. It worked fine in our lab, but LY got the same error in their environment.

% ./get_support_bundle.sh -a <MASKED_API_TOKEN> -n sysdigcloud

We could not determine the backend version. Exiting.

It does not seem to take into account the case where the Registry URL contains a port number, as in their environment.

  • LY’s environment:
% kubectl -n sysdigcloud get deployment sysdigcloud-api -ojsonpath='{.spec.template.spec.containers[0].image}' | awk -F: '{ print $2 }' | awk -F. '{ print $1 }'

4443/sysdig/sysdig-api


% kubectl -n sysdigcloud get deployment sysdigcloud-api -ojsonpath='{.spec.template.spec.containers[0].image}'                      

cd.docker-registry.corp.yahoo.co.jp:4443/sysdig/sysdig-api:6.11.0.240423000256
  • Our environment:
$ kubectl -n sysdig get deployment sysdigcloud-api -ojsonpath='{.spec.template.spec.containers[0].image}' | awk -F: '{ print $2 }' | awk -F. '{ print $1 }'
6

$ kubectl -n sysdig get deployment sysdigcloud-api -ojsonpath='{.spec.template.spec.containers[0].image}'
quay.io/sysdig/sysdig-api:6.11.0.240423000256

Can you make a further update to take into account cases where the Registry URL includes a port number, as in their environment? What about determining the version by customerVersion via api as described in this thread?
https://sysdigcloud.slack.com/archives/C03GJ1MN38Q/p1705660934469609?thread_ts=1705596392.908999&cid=C03GJ1MN38Q

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants