Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: amplify io is too large to hold in fuse buffer (#1311)
backport the logic of master commit c8a39c8 * fix: amplify io is too large to hold in fuse buffer Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned. Reproduction: run nydusd with 3MB amplify_io error from random io: reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" } Details: size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header) let amplify_io = min(user_specified, fuseWriter.available_bytes()) Resolution: This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs"). In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135"). Signed-off-by: 泰友 <[email protected]> * feat: e2e for amplify io larger than fuse buffer Signed-off-by: 泰友 <[email protected]> --------- Signed-off-by: 泰友 <[email protected]> Co-authored-by: 泰友 <[email protected]> Signed-off-by: Peng Tao <[email protected]>
- Loading branch information