feat: ZeroCopyWriter pass through available bytes from inner writer #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for writer of fixed buffer, such FuseDevWriter, VirtioFsWriter Signed-off-by: 泰友 <[email protected]>
ccx1024cc
requested review from
bergwolf,
imeoer,
jiangliu,
liubogithub and
eryugey
as code owners
ccx1024cc
pushed a commit
to ccx1024cc/image-service
that referenced
this pull request
Jun 5, 2023
Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned.
Reproduction:
run nydusd with 3MB amplify_io
The error from random io:
reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" }
Details:
size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header)
let amplify_io = min(user_specified, fuseWriter.available_bytes())
Resolution:
This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs").
In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135").
Signed-off-by: 泰友 <[email protected]>
ccx1024cc
pushed a commit
to ccx1024cc/image-service
that referenced
this pull request
Jun 5, 2023
Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned.
Reproduction:
run nydusd with 3MB amplify_io
error from random io:
reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" }
Details:
size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header)
let amplify_io = min(user_specified, fuseWriter.available_bytes())
Resolution:
This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs").
In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135").
Signed-off-by: 泰友 <[email protected]>
jiangliu
approved these changes
Jun 6, 2023
bergwolf
approved these changes
Jun 6, 2023
ccx1024cc
pushed a commit
to ccx1024cc/image-service
that referenced
this pull request
Jul 5, 2023
Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned.
Reproduction:
run nydusd with 3MB amplify_io
error from random io:
reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" }
Details:
size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header)
let amplify_io = min(user_specified, fuseWriter.available_bytes())
Resolution:
This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs").
In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135").
Signed-off-by: 泰友 <[email protected]>
ccx1024cc
pushed a commit
to ccx1024cc/image-service
that referenced
this pull request
Jul 6, 2023
Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned.
Reproduction:
run nydusd with 3MB amplify_io
error from random io:
reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" }
Details:
size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header)
let amplify_io = min(user_specified, fuseWriter.available_bytes())
Resolution:
This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs").
In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135").
Signed-off-by: 泰友 <[email protected]>
ccx1024cc
pushed a commit
to ccx1024cc/image-service
that referenced
this pull request
Jul 11, 2023
Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned.
Reproduction:
run nydusd with 3MB amplify_io
error from random io:
reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" }
Details:
size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header)
let amplify_io = min(user_specified, fuseWriter.available_bytes())
Resolution:
This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs").
In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135").
Signed-off-by: 泰友 <[email protected]>
ccx1024cc
added a commit
to dragonflyoss/nydus
that referenced
this pull request
Jul 12, 2023
* fix: amplify io is too large to hold in fuse buffer
Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned.
Reproduction:
run nydusd with 3MB amplify_io
error from random io:
reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" }
Details:
size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header)
let amplify_io = min(user_specified, fuseWriter.available_bytes())
Resolution:
This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs").
In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135").
Signed-off-by: 泰友 <[email protected]>
* feat: e2e for amplify io larger than fuse buffer
Signed-off-by: 泰友 <[email protected]>
---------
Signed-off-by: 泰友 <[email protected]>
Co-authored-by: 泰友 <[email protected]>
ccx1024cc
added a commit
to ccx1024cc/image-service
that referenced
this pull request
Jul 12, 2023
* fix: amplify io is too large to hold in fuse buffer
Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned.
Reproduction:
run nydusd with 3MB amplify_io
error from random io:
reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" }
Details:
size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header)
let amplify_io = min(user_specified, fuseWriter.available_bytes())
Resolution:
This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs").
In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135").
Signed-off-by: 泰友 <[email protected]>
* feat: e2e for amplify io larger than fuse buffer
Signed-off-by: 泰友 <[email protected]>
---------
Signed-off-by: 泰友 <[email protected]>
Co-authored-by: 泰友 <[email protected]>
ccx1024cc
added a commit
to ccx1024cc/image-service
that referenced
this pull request
Jul 12, 2023
* fix: amplify io is too large to hold in fuse buffer
Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned.
Reproduction:
run nydusd with 3MB amplify_io
error from random io:
reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" }
Details:
size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header)
let amplify_io = min(user_specified, fuseWriter.available_bytes())
Resolution:
This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs").
In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135").
Signed-off-by: 泰友 <[email protected]>
* feat: e2e for amplify io larger than fuse buffer
Signed-off-by: 泰友 <[email protected]>
---------
Signed-off-by: 泰友 <[email protected]>
Co-authored-by: 泰友 <[email protected]>
bergwolf
pushed a commit
to dragonflyoss/nydus
that referenced
this pull request
Jul 13, 2023
* fix: amplify io is too large to hold in fuse buffer
Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned.
Reproduction:
run nydusd with 3MB amplify_io
error from random io:
reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" }
Details:
size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header)
let amplify_io = min(user_specified, fuseWriter.available_bytes())
Resolution:
This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs").
In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135").
Signed-off-by: 泰友 <[email protected]>
* feat: e2e for amplify io larger than fuse buffer
Signed-off-by: 泰友 <[email protected]>
---------
Signed-off-by: 泰友 <[email protected]>
Co-authored-by: 泰友 <[email protected]>
bergwolf
pushed a commit
to bergwolf/nydus
that referenced
this pull request
Jul 13, 2023
backport the logic of master commit c8a39c8 * fix: amplify io is too large to hold in fuse buffer Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned. Reproduction: run nydusd with 3MB amplify_io error from random io: reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" } Details: size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header) let amplify_io = min(user_specified, fuseWriter.available_bytes()) Resolution: This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs"). In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135"). Signed-off-by: 泰友 <[email protected]> * feat: e2e for amplify io larger than fuse buffer Signed-off-by: 泰友 <[email protected]> --------- Signed-off-by: 泰友 <[email protected]> Co-authored-by: 泰友 <[email protected]> Signed-off-by: Peng Tao <[email protected]>
imeoer
pushed a commit
to dragonflyoss/nydus
that referenced
this pull request
Jul 17, 2023
backport the logic of master commit c8a39c8 * fix: amplify io is too large to hold in fuse buffer Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned. Reproduction: run nydusd with 3MB amplify_io error from random io: reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" } Details: size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header) let amplify_io = min(user_specified, fuseWriter.available_bytes()) Resolution: This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs"). In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135"). Signed-off-by: 泰友 <[email protected]> * feat: e2e for amplify io larger than fuse buffer Signed-off-by: 泰友 <[email protected]> --------- Signed-off-by: 泰友 <[email protected]> Co-authored-by: 泰友 <[email protected]> Signed-off-by: Peng Tao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for writer of fixed buffer, such FuseDevWriter, VirtioFsWriter