-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CRUD apis for role, permission, user #1801
feat: Add CRUD apis for role, permission, user #1801
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
==========================================
+ Coverage 77.08% 78.07% +0.99%
==========================================
Files 56 70 +14
Lines 8226 8488 +262
==========================================
+ Hits 6341 6627 +286
+ Misses 1885 1861 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…sk-AppBuilder into feat-user-management-api
…at-user-management-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good
flask_appbuilder/security/sqla/apis/permission_view_menu/api.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, gave it another quick review and tried things out. ping me if you have any blockers
flask_appbuilder/security/sqla/apis/permission_view_menu/api.py
Outdated
Show resolved
Hide resolved
…sk-AppBuilder into feat-user-management-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! left a couple of comments, thank you for your patience ;)
Description
Add permission, role, user CRUD apis.
ADDITIONAL INFORMATION