Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDPA-3203] Added pagination correct number highlighting fix. #559

Merged
merged 2 commits into from
Oct 9, 2019
Merged

[SDPA-3203] Added pagination correct number highlighting fix. #559

merged 2 commits into from
Oct 9, 2019

Conversation

MdNadimHossain
Copy link
Contributor

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-3203

Changed

  1. searchmixin 'this.pager.initialStep' value assign correction on the watch.
  2. On pagination index.vue, watch for totalsteps is removed because it was changing the value of currentsteps. This will fix the issue when you are at a certain page number on a search page and refreshing the page will still be highlighting at the correct page.

Screenshots

Screen Shot 2019-10-09 at 9 42 25 am

@MdNadimHossain MdNadimHossain self-assigned this Oct 8, 2019
@MdNadimHossain MdNadimHossain merged commit b3c4d53 into develop Oct 9, 2019
@MdNadimHossain MdNadimHossain deleted the feature/SDPA-3203-Pagination-inital-search-highlight-issue-fix branch October 9, 2019 02:49
tim-yao added a commit that referenced this pull request Oct 21, 2019
@tim-yao
Merge branch 'develop' into feature/SDPA-3169-update-readme-branding
5a0579b 
* develop: (63 commits)
  SDPA-3169 adds new branding (#567)
  v1.3.1
  Update create ripple app (#570)
  [SDPL-96] Split fieldRplSelect into its own component (#566)
  Fixed markup encode issue (#572)
  [SDPA-3207] Added style change for CallToAction to xs screen design. (#557)
  Updated the domain for the MyVIC endpoints in the MyVIC Maps. (#573)
  v1.3.0
  [SDPA-3270] Upgraded Nuxt to v2.9.2 (#561)
  [SDPA-3306] add mapping example (#555)
  [SDPA-3338] Fixed markup decode issue (#562)
  [SDPA-2949] Fix: Search results query to support filter object. (#528)
  [SDPA-3203] Added pagination correct number highlighting fix. (#559)
  [SDPA-3125] Added Flex for the small screen to make it two columns. (#552)
  [SDPA-3174] Added hero banner title size for smal & large screen. (#553)
  [SDPA-3192] Added Wordwrap mixin and used in rpl_banner_title. (#551)
  [SDPA-1967] Updated Honour role apply button text to match the design. (#550)
  [SDPA-2470] Added bottom padding for cta component in xs screen. (#549)
  Fix issues with e2e-vic-gov-au tests (#556)
  v1.3.0-alpha.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-yao tim-yao tim-yao approved these changes

@dylankelly dylankelly Awaiting requested review from dylankelly

@alan-cole alan-cole Awaiting requested review from alan-cole

Assignees

@MdNadimHossain MdNadimHossain

Labels
Ready for test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MdNadimHossain @tim-yao