Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPA-3125] Added Flex for the small screen to make it two columns. #552

Merged

Conversation

MdNadimHossain
Copy link
Contributor

@MdNadimHossain MdNadimHossain commented Sep 30, 2019

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-3125

Changed

  1. Added flex for related links and Whats's next component and removed the max-width for the small screen.
  2. Added minimum width to the list item, so that it becomes one column when the component width is at a certain level.

Screenshots

Screen Shot 2019-10-02 at 10 40 00 am
Screen Shot 2019-10-02 at 10 40 19 am

@tim-yao
Copy link
Contributor

tim-yao commented Oct 1, 2019

As discussed, please do a discovery on the improvement. @MdNadimHossain Cheers!

@MdNadimHossain MdNadimHossain merged commit b79d373 into develop Oct 9, 2019
@MdNadimHossain MdNadimHossain deleted the feature/SDPA-3125-Related-links-sm-screen-issue-fix branch October 9, 2019 01:38
tim-yao added a commit that referenced this pull request Oct 21, 2019
* develop: (63 commits)
  SDPA-3169 adds new branding (#567)
  v1.3.1
  Update create ripple app (#570)
  [SDPL-96] Split fieldRplSelect into its own component (#566)
  Fixed markup encode issue (#572)
  [SDPA-3207] Added style change for CallToAction to xs screen design. (#557)
  Updated the domain for the MyVIC endpoints in the MyVIC Maps. (#573)
  v1.3.0
  [SDPA-3270] Upgraded Nuxt to v2.9.2 (#561)
  [SDPA-3306] add mapping example (#555)
  [SDPA-3338] Fixed markup decode issue (#562)
  [SDPA-2949] Fix: Search results query to support filter object. (#528)
  [SDPA-3203] Added pagination correct number highlighting fix. (#559)
  [SDPA-3125] Added Flex for the small screen to make it two columns. (#552)
  [SDPA-3174] Added hero banner title size for smal & large screen. (#553)
  [SDPA-3192] Added Wordwrap mixin and used in rpl_banner_title. (#551)
  [SDPA-1967] Updated Honour role apply button text to match the design. (#550)
  [SDPA-2470] Added bottom padding for cta component in xs screen. (#549)
  Fix issues with e2e-vic-gov-au tests (#556)
  v1.3.0-alpha.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants