Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IOS_FCM_ENABLED variable to allow disabling FCM functionality on iOS #797

Merged
merged 1 commit into from
May 22, 2023

Conversation

aleh
Copy link

@aleh aleh commented Apr 4, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

There is a conflict on iOS in case push notifications are handled by another plugin (Airship), i.e. when FCM functionality of the plugin is not used. Even with FIREBASE_FCM_AUTOINIT_ENABLED set to false the plugin still would set its delegate for UNUserNotificationCenter however preventing regular flow of notifications. This PR is allows to disable FCM on iOS via IOS_FCM_ENABLED variable.

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

Checked in an isolated example and used in a production app.

What testing has been done on existing functionality?

Other information

@dpa99c dpa99c closed this in b47eb31 May 22, 2023
@dpa99c dpa99c merged commit b47eb31 into dpa99c:master May 22, 2023
@aleh
Copy link
Author

aleh commented May 22, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants