Describe status constants possible values #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
should be ready for review now :-) |
Allows to reference those constants in a typesafe manner
|
Also, note that I prepared a branch, on my local repo, targetting version 4.x : https://github.com/fcamblor/cordova-diagnostic-plugin/tree/ts-4x-constants I cannot propose any PR yet for 4.x as there is no real branch targetting this branch currently on your repository :) |
|
Great, thanks for this. |
|
This has been published in v5.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What is the purpose of this PR?
Today, for example, we are not able to use
motionStatusconstants in a typesafe manner (there is no check on the existence of this or that motion status since the type isany)This PR aims at fixing this.
Does this PR introduce a breaking change?
Conceptually, yes, this is a breaking change in terms of type descriptor (today's
anyhas a wider type space than the one I'm proposing)However, this is for good : people using
window.cordova.plugins.diagnostic.motionStatus.NOT_DETERMINNED(typo in the name) in their code were not having any error, and now they will have some.Note that it may help pinpoint migration issues introduced recently (like #230) in case people doesn't read the changelog :-)