DENIED~ish permission statuses aren't similar across platforms

[josh-m-sharpe]

It seems that DENIED on ios is that same as DENIED_ALWAYS on android. So, if I wanted to check for this "never can ask again" status and direct the user to their settings page, I would need to check different constants on different platforms.

Proposed changes:

Make both platforms have the same constant for the state where the permission is denied and cannot be prompted again. (DENIED_ALWAYS)
On Android, change DENIED to DENIED_PREVIOUSLY.

[dpa99c]

Thanks for suggesting this and it's is true that DENIED on ios is that same as DENIED_ALWAYS. It arises historically from earlier versions of this plugin where the constants were separate enums. However, this would be a backwardly-incompatible change that would break the many apps out there which are already using this plugin and its constants as they are currently defined. For this reason, I don't think that making this change is a good idea, given that the workaround needed is fairly trivial:

function isPermanentlyDenied(status){
  return (device.platform === "iOS" && status === cordova.plugins.diagnostic.permissionStatus.DENIED) 
  || (device.platform === "Android" && status === cordova.plugins.diagnostic.permissionStatus.DENIED_ALWAYS);
}

if(isPermanentlyDenied(status){
  ...
}

[ciekawy]

what about creating new non confusing enum names and deprecate old ones keeping deprecated ones long enough for people to switch?

I found this plugin to be great help also to hide platform inconsistencies and here even if trivial thats not a nice piece of code...

[dpa99c]

Ok, let's address this in the next plugin version

[dpa99c]

I propose that DENIED on Android is deprecated in favour of DENIED_ONCE and DENIED on iOS is deprecated in favour of DENIED_ALWAYS which means DENIED_ALWAYS is semantically the same on both platforms.

[dpa99c]

I propose that DENIED on Android is deprecated in favour of DENIED_ONCE and DENIED on iOS is deprecated in favour of DENIED_ALWAYS which means DENIED_ALWAYS is semantically the same on both platforms.

During implementation I realised that deprecating DENIED is not possible since it's a return value, therefore this is going to be a hard, breaking change to the API and therefore a major version bump. Brace yourselves!