Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Stream overrides #2

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

stephentoub
Copy link
Contributor

It's important for perf to override the base implementations, in particular for Read/WriteByte.

I just copied the existing implementations to the new overrides and fixed up the implementations with as minimal changes as possible. I also tried to retain the style of the surrounding code.

And none of the existing implementations have tests, so I didn't add any for these, as much as it pained me :)

It's important for perf to override the base implementations, in particular for Read/WriteByte.

I just copied the existing implementations to the new overrides and fixed up the implementations with as minimal changes as possible. I also tried to retain the style of the surrounding code.

And none of the existing implementations have tests, so I didn't add any for these, as much as it pained me :)
Copy link
Contributor

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry about the tests :-(
I'll try fine some time to cover this

@JanKrivanek JanKrivanek merged commit a686847 into dotutils:main Sep 17, 2024
1 check passed
@stephentoub stephentoub deleted the addoverrides branch September 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants