Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated DotUtils to avoid lots of expensive Stream.ReadByte calls #820

Closed
stephentoub opened this issue Sep 17, 2024 · 1 comment · Fixed by #822
Closed

Use updated DotUtils to avoid lots of expensive Stream.ReadByte calls #820

stephentoub opened this issue Sep 17, 2024 · 1 comment · Fixed by #822
Assignees

Comments

@stephentoub
Copy link
Contributor

The DotUtils library provides some Stream types used here. Lots of calls end up getting made to those Stream's ReadByte methods, but it hasn't overridden them, such that the (expensive) base implementations are used. I submitted dotutils/streamutils#2 to add those overrides. If/when that's merged and a new package is created that has the updated code, this project should be updated to use the newer version.

@KirillOsenkov
Copy link
Owner

KirillOsenkov commented Sep 17, 2024

Original:
image

Low-hanging fruit removed:
image

This PR:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants