Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Fail CI build if APICompat baseline files would change #1185

Merged
merged 2 commits into from
May 14, 2019
Merged

Fail CI build if APICompat baseline files would change #1185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1d799b
Fail CI build if APICompat baseline files would change
wtgodbe May 10, 2019
efcc3ad
Set BaselineAllAPICompatError based on ContinuousIntegrationBuild
wtgodbe May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@
<Platform>AnyCPU</Platform>
<OutputType>Library</OutputType>
<RunApiCompat>$(IsSourceProject)</RunApiCompat>
<BaselineAllAPICompatError Condition="'$(BaselineAllAPICompatError)' == ''">true</BaselineAllAPICompatError>
<BaselineAllAPICompatError Condition="'$(ContinuousIntegrationBuild)' == 'true'">false</BaselineAllAPICompatError>
<LangVersion>latest</LangVersion> <!-- default to allowing all language features -->
</PropertyGroup>

Expand Down
3 changes: 2 additions & 1 deletion src/apicompat/apicompat.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,8 @@
<ApiCompatArgs>$(ApiCompatArgs) --contract-depends "$(ApiCompatContracts)"</ApiCompatArgs>
<ApiCompatArgs>$(ApiCompatArgs) --exclude-attributes "$(SourceDir)platforms\attributeExcludeList.txt"</ApiCompatArgs>
<ApiCompatArgs>$(ApiCompatArgs) --impl-dirs "$(NetstandardRefPath),$(NetstandardShimsPath),$(NetfxShimsPath)"</ApiCompatArgs>
<ApiCompatBaselineAll>&gt; "$(ApiCompatBaselineFile)"</ApiCompatBaselineAll>
<ApiCompatArgs Condition="'$(BaselineAllAPICompatError)' != 'true' and Exists('$(ApiCompatBaselineFile)')">$(ApiCompatArgs) --baseline "$(ApiCompatBaselineFile)"</ApiCompatArgs>
<ApiCompatBaselineAll Condition="'$(BaselineAllAPICompatError)' == 'true'">&gt; $(ApiCompatBaselineFile)</ApiCompatBaselineAll>
<ApiCompatExitCode>0</ApiCompatExitCode>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion src/netstandard/src/netstandard.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<ResolveMatchingContract>true</ResolveMatchingContract>
<RunApiCompatForSrc>true</RunApiCompatForSrc>
<RunMatchingRefApiCompat>false</RunMatchingRefApiCompat>
<BaselineAllAPICompatError>true</BaselineAllAPICompatError>
<ApiCompatBaseline>$(MSBuildProjectDirectory)\ApiCompatBaseline.$(TargetFramework).txt</ApiCompatBaseline>
<NoWarn>$(NoWarn);618</NoWarn>
</PropertyGroup>
Expand Down