Fail CI build if APICompat baseline files would change #1185
Conversation
azure-pipelines.yml
Outdated
| @@ -58,13 +58,15 @@ jobs: | |||
| /p:DotNetSymbolServerTokenMsdl=$(microsoft-symbol-server-pat) | |||
| /p:DotNetSymbolServerTokenSymWeb=$(symweb-symbol-server-pat) | |||
| /p:OfficialBuildId=$(BUILD.BUILDNUMBER) | |||
| /p:BaselineAllAPICompatError=false | |||
There was a problem hiding this comment.
@ericstj the -ci switch doesn't specifically set any msbuild properties, so I had to pass this in explicitly
There was a problem hiding this comment.
Are you sure? We depend on properties elsewhere, let me dig something up.
There was a problem hiding this comment.
Arcade should set ContinuousIntegrationBuild property, which does appear to be set for standard builds: https://dev.azure.com/dnceng/public/_build/results?buildId=185990&view=logs&jobId=63b49790-6233-5870-8977-1ff42860cf98&taskId=d5ac7b83-d192-58c9-3d0d-9ab0cb98f90f&lineStart=31&lineEnd=31&colStart=240&colEnd=274
There was a problem hiding this comment.
Ah, looks like you're right. I was only looking at what we pass in Build.ps1, but I missed https://github.com/dotnet/arcade/blob/f15f32d01fcf5d7f60f2246faf6db5b337e72f45/eng/common/tools.ps1#L510. Will update the PR.
Currently, if a change in Arcade would cause changes in the APICompat baseline files, the baseline files are rewritten without throwing an error. If somebody makes such a change without checking in the changes to the APICompat baselines, the CI should fail. This change achieves that. Resolves #1184.
@ericstj @terrajobst PTAL