Use asset manifests exclusively to produce/consume previously source built artifacts #40745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…med from the bootstrap.
…bootstrap tarball for the build to find
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ViktorHofer
reviewed
May 8, 2024
| @@ -153,7 +157,7 @@ | |||
|
|
|||
| <!-- Repack tarball with new bootstrap name --> | |||
| <Message Text=" Repacking tarball to $(NewTarballName)" Importance="High" /> | |||
| <Exec Command="tar --numeric-owner -czf $(NewTarballName) *.nupkg *.props SourceBuildReferencePackages/" WorkingDirectory="$(UnpackedTarPath)" /> | |||
| <Exec Command="tar --numeric-owner -czf $(NewTarballName) *.nupkg *.props *.xml SourceBuildReferencePackages/" WorkingDirectory="$(UnpackedTarPath)" /> | |||
There was a problem hiding this comment.
Should the .xml glob also be more specific?
There was a problem hiding this comment.
I wanted to follow the existing pattern, so I did the same thing we do with PackageVersions.props (use a glob). I'd rather leave it that way and clean up both in the future than have one do one thing and another do something different.
ViktorHofer
approved these changes
May 8, 2024
|
The sdk-unified-build test failure is unrelated and will go away when you update your branch to target latest main. |
|
Filed dotnet/source-build#4390 for the sdk-unified-build failure |
ViktorHofer
added
Area-VMR
source-build
and removed
Area-Infrastructure
source-build
untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the consumption of the previously source-built artifacts and the production of the PackageVersions.props to insert into the bootstrap tarball to both be produced from asset manifests.
This allows us to remove the split in the logic between either using the asset manifests or cracking open NuGet packages.
This is a rebased/cleaned up version of dotnet/installer#19585