Use asset manifests exclusively to produce/consume previously source built artifacts #19585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
commented
Apr 26, 2024
…bootstrap tarball for the build to find
jkoritzinsky
requested review from
ViktorHofer,
mmitche and
ellahathaway
and removed request for
a team
ViktorHofer
requested changes
May 1, 2024
There was a problem hiding this comment.
Please don't merge this until #19594 is merged and we have a new official build so that we can do a re-bootstrap.
|
I'm fine holding off on merging. Any other feedback on this PR? |
ViktorHofer
reviewed
May 2, 2024
|
Look good but please let's wait with merging until Monday. We still haven't got a new SDK out that we can use. |
ViktorHofer
requested changes
May 7, 2024
There was a problem hiding this comment.
As part of the installer->sdk repository consolidation we are already switching the VMR over into dotnet/sdk. ETA: today or tomorrow. The last manual code sync happened today and we don't plan on doing another sync. Please close this PR and submit it into dotnet/sdk. Sorry for the inconvenience.
|
Moved to dotnet/sdk as dotnet/sdk#40745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the consumption of the previously source-built artifacts and the production of the PackageVersions.props to insert into the bootstrap tarball to both be produced from asset manifests.
This allows us to remove the split in the logic between either using the asset manifests or cracking open NuGet packages.